From: tip-bot for Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
randy.dunlap@oracle.com, davem@davemloft.net,
anil.s.keshavamurthy@intel.com, ananth@in.ibm.com,
masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org,
tglx@linutronix.de, felipe.contreras@gmail.com, mingo@elte.hu
Subject: [tip:perf/urgent] kprobes: Fix Kconfig dependency
Date: Mon, 13 Sep 2010 19:54:47 GMT [thread overview]
Message-ID: <tip-05ed160e89baf7f5fb3432d527fec467d2493626@git.kernel.org> (raw)
In-Reply-To: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp>
Commit-ID: 05ed160e89baf7f5fb3432d527fec467d2493626
Gitweb: http://git.kernel.org/tip/05ed160e89baf7f5fb3432d527fec467d2493626
Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Mon, 13 Sep 2010 19:25:41 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 13 Sep 2010 20:41:31 +0200
kprobes: Fix Kconfig dependency
Fix Kconfig dependency among Kprobes, optprobe and kallsyms.
Kprobes uses kallsyms_lookup for finding target function and
checking instruction boundary, thus CONFIG_KPROBES should select
CONFIG_KALLSYMS.
Optprobe is an optional feature which is supported on x86 arch,
and it also uses kallsyms_lookup for checking instructions in
the target function. Since KALLSYMS_ALL just adds symbols of
kernel variables, it doesn't need to select KALLSYMS_ALL.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>,
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: akpm <akpm@linux-foundation.org>
LKML-Reference: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig
index 4877a8c..fe48fc7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -32,8 +32,9 @@ config HAVE_OPROFILE
config KPROBES
bool "Kprobes"
- depends on KALLSYMS && MODULES
+ depends on MODULES
depends on HAVE_KPROBES
+ select KALLSYMS
help
Kprobes allows you to trap at almost any kernel address and
execute a callback function. register_kprobe() establishes
@@ -45,7 +46,6 @@ config OPTPROBES
def_bool y
depends on KPROBES && HAVE_OPTPROBES
depends on !PREEMPT
- select KALLSYMS_ALL
config HAVE_EFFICIENT_UNALIGNED_ACCESS
bool
prev parent reply other threads:[~2010-09-13 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 19:26 [PATCH -next] optprobes: fix kconfig depends/selects Randy Dunlap
2010-08-17 14:55 ` Masami Hiramatsu
2010-08-17 15:03 ` Masami Hiramatsu
2010-09-12 10:49 ` Felipe Contreras
2010-09-12 18:34 ` Randy Dunlap
2010-09-12 18:41 ` Felipe Contreras
2010-09-12 18:46 ` Randy Dunlap
2010-09-13 1:06 ` Masami Hiramatsu
2010-09-13 7:15 ` Masami Hiramatsu
2010-09-13 9:41 ` Felipe Contreras
2010-09-13 10:14 ` Masami Hiramatsu
2010-09-13 11:11 ` Felipe Contreras
2010-09-13 10:25 ` [PATCH -next,-tip ] kprobes: Fix Kconfig dependency Masami Hiramatsu
2010-09-13 16:33 ` Randy Dunlap
2010-09-13 19:54 ` tip-bot for Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-05ed160e89baf7f5fb3432d527fec467d2493626@git.kernel.org \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=felipe.contreras@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox