Re: [tip:perfcounters/core] perf_counter, x86: remove X86_FEATURE_ARCH_PERFMON flag for AMD cpus

Robert Richter
2009-05-11T12:41:49Z

On 11.05.09 17:43:44, Jaswinder Singh Rajput wrote:
> On Sun, 2009-05-10 at 08:30 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Intel Architectural PerfMon */
> > > > should be replaced by
> > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Performace Monitor */
> > > >
> > > > All x86 cpus which support performance monitor should set this feature.
> > > >
> > >
> > > Currently X86_FEATURE_ARCH_PERFMON is enabled for >= Intel Core2
> > >
> > > But Performance monitor is almost supported by all Intel
> > > processors. I am adding few MSRs list for reference to see
> > > complete list please check arch/x86/kernel/cpu/cpu_debug.c
> >
> > I think you are confusing two things:
> >
> > - The 'architectural perfmon' CPU flag, enumerated in CPUID. (this
> > is a relatively new CPUID flag that only Intel CPUs at around
> > Core2 and later will report.)
> >
> > - The concept of 'performance monitoring' - which has been present
> > in various x86 CPUs starting at the original Pentium (P5) 15 years
> > ago or so.
> >
>
> Here is the patch for review for ancient performance monitoring
> cpufeature, complete cpu_debug and cpu_feature patches are available
> at :
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip.git;a=summary
>
> Subject: [PATCH] x86: Add cpufeature for ancient performance monitoring

Jaswinder,

which branch is this patch against? It is not tip/perfcounters/core
nor tip/master.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com