Re: [PATCH 0/29] x86/perfcounters: x86 and AMD cpu updates

Peter Zijlstra
2009-04-29T11:22:59Z

On Wed, 2009-04-29 at 13:09 +0200, Ingo Molnar wrote:
> * Robert Richter <robert.richter@amd.com> wrote:
>
> > This patch series updates the perfcounters implementation mainly
> > for the x86 architecture.
>
> Wow, very nice series! Still havent looked through all of them, but
> wanted to give some quick feedback that the splitup and direction
> looks all good.

Agreed, patches look nice, thanks!

> > I developed this patches based on 03ced43 and later rebased to
> > 1b88991. The latest tip/percounters/core branch seems to be
> > broken, no nmis are delivered, only perfcounter interrupts with no
> > results on kerneltop. I am still debugging this. However, I could
> > test successfully the patch series based on 03ced43 and want to
> > release the patches anyway.
>
> hm, it works all fine for me. This is "perf top" output from an
> AMD/Barcelona box:

Works on my opteron as well:

vendor_id : AuthenticAMD
cpu family : 15
model : 67
model name : Dual-Core AMD Opteron(tm) Processor 1216
stepping : 2