From: tip-bot for Davidlohr Bueso <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: dave@stgolabs.net, hpa@zytor.com, dbueso@suse.de,
linux-kernel@vger.kernel.org, mingo@kernel.org,
longman@redhat.com, tglx@linutronix.de
Subject: [tip:locking/core] sched/wake_q: Clarify queue reinit comment
Date: Wed, 1 Feb 2017 02:08:54 -0800 [thread overview]
Message-ID: <tip-0754445d71c37a7afd4f0790a9be4cf53c1b8cc4@git.kernel.org> (raw)
In-Reply-To: <20170129151531.GA2444@linux-80c1.suse>
Commit-ID: 0754445d71c37a7afd4f0790a9be4cf53c1b8cc4
Gitweb: http://git.kernel.org/tip/0754445d71c37a7afd4f0790a9be4cf53c1b8cc4
Author: Davidlohr Bueso <dave@stgolabs.net>
AuthorDate: Sun, 29 Jan 2017 07:15:31 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 1 Feb 2017 10:02:18 +0100
sched/wake_q: Clarify queue reinit comment
As of:
bcc9a76d5ac ("locking/rwsem: Reinit wake_q after use")
the comment regarding the list reinitialization no longer applies,
update it with the new wake_q_init() helper.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Acked-by: Waiman Long <longman@redhat.com>
Cc: peterz@infradead.org
Cc: longman@redhat.com
Cc: akpm@linux-foundation.org
Cc: paulmck@linux.vnet.ibm.com
Cc: torvalds@linux-foundation.org
Link: http://lkml.kernel.org/r/20170129151531.GA2444@linux-80c1.suse
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 4e62b37..1cc0ded 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1000,8 +1000,8 @@ enum cpu_idle_type {
*
* The DEFINE_WAKE_Q macro declares and initializes the list head.
* wake_up_q() does NOT reinitialize the list; it's expected to be
- * called near the end of a function, where the fact that the queue is
- * not used again will be easy to see by inspection.
+ * called near the end of a function. Otherwise, the list can be
+ * re-initialized for later re-use by wake_q_init().
*
* Note that this can cause spurious wakeups. schedule() callers
* must ensure the call is done inside a loop, confirming that the
prev parent reply other threads:[~2017-02-01 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 2:33 [PATCH] locking/rwsem: Reinit wake_q after use Waiman Long
2017-01-22 10:14 ` [tip:locking/core] " tip-bot for Waiman Long
2017-01-29 15:15 ` [PATCH -tip] sched/wake_q: Clarify queue reinit Davidlohr Bueso
2017-01-29 16:22 ` Waiman Long
2017-02-01 10:08 ` tip-bot for Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0754445d71c37a7afd4f0790a9be4cf53c1b8cc4@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox