From: tip-bot for Jan Beulich <JBeulich@novell.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jbeulich@novell.com, heukelum@fastmail.fm, JBeulich@novell.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/debug] x86, asm: Restore parentheses around one pushl_cfi argument
Date: Fri, 22 Oct 2010 09:56:13 GMT [thread overview]
Message-ID: <tip-07bd8516a2f967aa67904c68ab97bb896a448b09@git.kernel.org> (raw)
In-Reply-To: <4CC157DB020000780001E8A2@vpn.id2.novell.com>
Commit-ID: 07bd8516a2f967aa67904c68ab97bb896a448b09
Gitweb: http://git.kernel.org/tip/07bd8516a2f967aa67904c68ab97bb896a448b09
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Fri, 22 Oct 2010 08:22:35 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 22 Oct 2010 10:51:44 +0200
x86, asm: Restore parentheses around one pushl_cfi argument
These were (intentionally) stripped by "fix CFI macro
invocations to deal with shortcomings in gas" to expose problems
with unexpected splitting of arguments by older gas also on
newer versions, but as it turns out there is at least one distro
(Ubuntu 6.06) where even not having *any* spaces in a macro
argument doesn't reliably prevent splitting into multiple
arguments.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
LKML-Reference: <4CC157DB020000780001E8A2@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/entry_32.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index f73a4b8..59e175e 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -395,7 +395,7 @@ sysenter_past_esp:
* A tiny bit of offset fixup is necessary - 4*4 means the 4 words
* pushed above; +8 corresponds to copy_thread's esp0 setting.
*/
- pushl_cfi TI_sysenter_return-THREAD_SIZE_asm+8+4*4(%esp)
+ pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
CFI_REL_OFFSET eip, 0
pushl_cfi %eax
prev parent reply other threads:[~2010-10-22 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 7:22 [PATCH] i386: restore parentheses around one pushl_cfi argument Jan Beulich
2010-10-22 9:56 ` tip-bot for Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-07bd8516a2f967aa67904c68ab97bb896a448b09@git.kernel.org \
--to=jbeulich@novell.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox