Re: [rfc 1/4] x86: irq.c - tiny cleanup

Ingo Molnar
2009-04-12T17:26:23Z

* Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> Impact: cleanup
>
> 1) guard ack_bad_irq with printk_ratelimit since there is no
> guarantee we will not be flooded one day
> 2) use pr_emerg helper
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> arch/x86/kernel/irq.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> Index: linux-2.6.git/arch/x86/kernel/irq.c
> =====================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/irq.c
> +++ linux-2.6.git/arch/x86/kernel/irq.c
> @@ -24,7 +24,8 @@ void (*generic_interrupt_extension)(void
> */
> void ack_bad_irq(unsigned int irq)
> {
> - printk(KERN_ERR "unexpected IRQ trap at vector %02x\n", irq);
> + if (printk_ratelimit())
> + pr_err("unexpected IRQ trap at vector %02x\n", irq);

Btw, this is not so theoretical - in the past i've had bugs where a
flood of these messages made the system unusable. (granted, it would
have been unusable even with rate-limiting - but it's still nice to
have a throttle in place for something like this.)

Ingo