From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933783AbcAMJn0 (ORCPT ); Wed, 13 Jan 2016 04:43:26 -0500 Received: from terminus.zytor.com ([198.137.202.10]:48789 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754458AbcAMJnU (ORCPT ); Wed, 13 Jan 2016 04:43:20 -0500 Date: Wed, 13 Jan 2016 01:42:44 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: dsahern@gmail.com, mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, andi@firstfloor.org, jolsa@kernel.org, wangnan0@huawei.com, peterz@infradead.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, acme@redhat.com Reply-To: namhyung@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, dsahern@gmail.com, wangnan0@huawei.com, jolsa@kernel.org, andi@firstfloor.org, hpa@zytor.com In-Reply-To: <1452509594-13616-1-git-send-email-namhyung@kernel.org> References: <1452509594-13616-1-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf ui/tui: Print helpline message as is Git-Commit-ID: 090cff3eae8f02395009972d01b5dfdb95bcc327 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 090cff3eae8f02395009972d01b5dfdb95bcc327 Gitweb: http://git.kernel.org/tip/090cff3eae8f02395009972d01b5dfdb95bcc327 Author: Namhyung Kim AuthorDate: Mon, 11 Jan 2016 19:53:14 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 12 Jan 2016 12:42:08 -0300 perf ui/tui: Print helpline message as is When a tip message contains a percent sign, it was treated printf format specifier so broken string was printed like below. Tip: Limit to show entries above 577nly: perf report --percent-limit 5 ^^^ As ui_browser__show receives format string, pass additional "%s" so that the help (tip) message can be printed as is. Tip: Limit to show entries above 5% only: perf report --percent-limit 5 Signed-off-by: Namhyung Kim Cc: Andi Kleen Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/1452509594-13616-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 901d481..08c09ad 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -480,7 +480,7 @@ static int hist_browser__run(struct hist_browser *browser, const char *help) hists__browser_title(browser->hists, hbt, title, sizeof(title)); - if (ui_browser__show(&browser->b, title, help) < 0) + if (ui_browser__show(&browser->b, title, "%s", help) < 0) return -1; while (1) {