From: tip-bot for Arnd Bergmann <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, hpa@zytor.com,
natechancellor@gmail.com, tglx@linutronix.de, mingo@kernel.org
Subject: [tip:timers/urgent] timekeeping/vsyscall: Use __iter_div_u64_rem()
Date: Wed, 10 Jul 2019 11:43:15 -0700 [thread overview]
Message-ID: <tip-0df1c9868c3a1916198ee09c323ca5932a0b8a11@git.kernel.org> (raw)
In-Reply-To: <20190710130206.1670830-1-arnd@arndb.de>
Commit-ID: 0df1c9868c3a1916198ee09c323ca5932a0b8a11
Gitweb: https://git.kernel.org/tip/0df1c9868c3a1916198ee09c323ca5932a0b8a11
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Wed, 10 Jul 2019 15:01:53 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 10 Jul 2019 20:37:49 +0200
timekeeping/vsyscall: Use __iter_div_u64_rem()
On 32-bit x86 when building with clang-9, the 'division' loop gets turned
back into an inefficient division that causes a link error:
kernel/time/vsyscall.o: In function `update_vsyscall':
vsyscall.c:(.text+0xe3): undefined reference to `__udivdi3'
Use the existing __iter_div_u64_rem() function which is used to address the
same issue in other places.
Fixes: 44f57d788e7d ("timekeeping: Provide a generic update_vsyscall() implementation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lkml.kernel.org/r/20190710130206.1670830-1-arnd@arndb.de
---
kernel/time/vsyscall.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/time/vsyscall.c b/kernel/time/vsyscall.c
index a80893180826..8cf3596a4ce6 100644
--- a/kernel/time/vsyscall.c
+++ b/kernel/time/vsyscall.c
@@ -104,11 +104,7 @@ void update_vsyscall(struct timekeeper *tk)
vdso_ts->sec = tk->xtime_sec + tk->wall_to_monotonic.tv_sec;
nsec = tk->tkr_mono.xtime_nsec >> tk->tkr_mono.shift;
nsec = nsec + tk->wall_to_monotonic.tv_nsec;
- while (nsec >= NSEC_PER_SEC) {
- nsec = nsec - NSEC_PER_SEC;
- vdso_ts->sec++;
- }
- vdso_ts->nsec = nsec;
+ vdso_ts->sec += __iter_div_u64_rem(nsec, NSEC_PER_SEC, &vdso_ts->nsec);
if (__arch_use_vsyscall(vdata))
update_vdso_data(vdata, tk);
next prev parent reply other threads:[~2019-07-10 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 13:01 [PATCH] vsyscall: use __iter_div_u64_rem() Arnd Bergmann
2019-07-10 15:22 ` [tip:timers/urgent] timekeeping/vsyscall: Use __iter_div_u64_rem() tip-bot for Arnd Bergmann
2019-07-10 16:56 ` [PATCH] vsyscall: use __iter_div_u64_rem() Nathan Chancellor
2019-07-10 18:43 ` tip-bot for Arnd Bergmann [this message]
2019-07-11 12:14 ` Vincenzo Frascino
2019-07-11 12:28 ` Arnd Bergmann
2019-07-11 13:08 ` Vincenzo Frascino
2019-07-11 17:14 ` Nick Desaulniers
2019-07-11 20:55 ` Arnd Bergmann
2019-07-22 10:10 ` Thomas Gleixner
2019-07-22 10:38 ` Jan Beulich
2019-07-22 10:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0df1c9868c3a1916198ee09c323ca5932a0b8a11@git.kernel.org \
--to=tipbot@zytor.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=natechancellor@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox