public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mathieu.desnoyers@polymtl.ca,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:tracing/core] tracing, Text Edit Lock - Architecture Independent Code
Date: Sun, 8 Mar 2009 15:51:24 GMT	[thread overview]
Message-ID: <tip-0e39ac444636ff5be39b26f1cb56d79594654dda@git.kernel.org> (raw)
In-Reply-To: <49B142D8.7020601@redhat.com>

Commit-ID:  0e39ac444636ff5be39b26f1cb56d79594654dda
Gitweb:     http://git.kernel.org/tip/0e39ac444636ff5be39b26f1cb56d79594654dda
Author:     "Mathieu Desnoyers" <mathieu.desnoyers@polymtl.ca>
AuthorDate: Fri, 6 Mar 2009 10:35:52 -0500
Commit:     Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 6 Mar 2009 16:48:59 +0100

tracing, Text Edit Lock - Architecture Independent Code

This is an architecture independant synchronization around kernel text
modifications through use of a global mutex.

A mutex has been chosen so that kprobes, the main user of this, can sleep
during memory allocation between the memory read of the instructions it
must replace and the memory write of the breakpoint.

Other user of this interface: immediate values.

Paravirt and alternatives are always done when SMP is inactive, so there
is no need to use locks.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
LKML-Reference: <49B142D8.7020601@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 include/linux/memory.h |    6 ++++++
 mm/memory.c            |   10 ++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/include/linux/memory.h b/include/linux/memory.h
index 3fdc108..86a6c0f 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -99,4 +99,10 @@ enum mem_add_context { BOOT, HOTPLUG };
 #define hotplug_memory_notifier(fn, pri) do { } while (0)
 #endif
 
+/*
+ * Kernel text modification mutex, used for code patching. Users of this lock
+ * can sleep.
+ */
+extern struct mutex text_mutex;
+
 #endif /* _LINUX_MEMORY_H_ */
diff --git a/mm/memory.c b/mm/memory.c
index baa999e..05fab3b 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -48,6 +48,8 @@
 #include <linux/rmap.h>
 #include <linux/module.h>
 #include <linux/delayacct.h>
+#include <linux/kprobes.h>
+#include <linux/mutex.h>
 #include <linux/init.h>
 #include <linux/writeback.h>
 #include <linux/memcontrol.h>
@@ -99,6 +101,14 @@ int randomize_va_space __read_mostly =
 					2;
 #endif
 
+/*
+ * mutex protecting text section modification (dynamic code patching).
+ * some users need to sleep (allocating memory...) while they hold this lock.
+ *
+ * NOT exported to modules - patching kernel text is a really delicate matter.
+ */
+DEFINE_MUTEX(text_mutex);
+
 static int __init disable_randmaps(char *s)
 {
 	randomize_va_space = 0;

  reply	other threads:[~2009-03-08 15:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 15:34 [PATCH -tip 0/4] Text edit lock and atomic text_poke() Masami Hiramatsu
2009-03-06 15:35 ` [PATCH -tip 1/4] Text Edit Lock - Architecture Independent Code (v2) Masami Hiramatsu
2009-03-08 15:51   ` Mathieu Desnoyers [this message]
2009-03-06 15:36 ` [PATCH -tip 2/4]Text Edit Lock - kprobes architecture independent support (v3) Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] tracing, Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2009-03-06 15:37 ` [PATCH -tip 3/4]Text Edit Lock - Smp alternatives support Masami Hiramatsu
2009-03-06 18:11   ` Mathieu Desnoyers
2009-03-06 18:40     ` Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] tracing, Text Edit Lock - SMP " Masami Hiramatsu
2009-03-06 15:37 ` [PATCH -tip 4/4] Atomic text_poke() with fixmap Masami Hiramatsu
2009-03-06 18:13   ` Mathieu Desnoyers
2009-03-06 18:18     ` Ingo Molnar
2009-03-06 18:33     ` [PATCH -tip 4/4] Atomic text_poke() with fixmap take2 Masami Hiramatsu
2009-03-06 18:45       ` Mathieu Desnoyers
2009-03-06 19:08       ` Ingo Molnar
2009-03-06 19:15         ` Mathieu Desnoyers
2009-03-06 19:22           ` Ingo Molnar
2009-03-06 20:25             ` [PATCH -tip 5/4] Expands irq-off region in text_poke() Masami Hiramatsu
2009-03-06 21:01               ` Mathieu Desnoyers
2009-03-06 21:57                 ` Masami Hiramatsu
2009-03-07  1:42                   ` Mathieu Desnoyers
2009-03-09 16:40                     ` Masami Hiramatsu
2009-03-10 21:57                       ` [tip:tracing/core] x86: expand " Masami Hiramatsu
2009-03-08 15:51   ` [tip:tracing/core] x86: implement atomic text_poke() via fixmap Masami Hiramatsu
2009-03-06 18:09 ` [PATCH -tip 0/4] Text edit lock and atomic text_poke() Mathieu Desnoyers
2009-03-06 18:12   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0e39ac444636ff5be39b26f1cb56d79594654dda@git.kernel.org \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox