Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory

Borislav Petkov
2018-11-23T08:23:10Z

On Fri, Nov 23, 2018 at 08:28:39AM +0100, Ingo Molnar wrote:
> Ugh, violent NAK on this unreadable directory naming: 'resctrl' is an
> ugly double/triple abbreviation that nobody recognizes for what it is to
> begin with, and even the long form 'resource control' is an overly
> generic naming - *everything* the kernel does is in essence 'resource
> control' ...

Well, the fs this thing uses is called "resctrl".

Documentation/x86/resctrl_ui.txt:1075:the resctrl will still mount but cannot create CTRL_MON directories.
Documentation/x86/resctrl_ui.txt:1082:# mount -t resctrl resctrl /sys/fs/resctrl
Documentation/x86/resctrl_ui.txt:1083:# cd /sys/fs/resctrl

Are you saying that the fs should be renamed now too?

> So please find some better name and standardize the namespace around it.
> A couple of suggestions:
>
> - 'Hardware Quality of Service', i.e. HW_QOS, hw_qos
> - or 'CPU bandwidth control', i.e. CPU_BW, cpu_bw
> - or 'Hardware Bandwidth Control', i.e. HW_BW, hw_bw

How are those *abbreviations* better? "hw_bw" is especially cryptic and
the others are no better.

"resctrl" to mean "resource control" is much better IMO. And it is
different from the "other" resource controlling the kernel does because
it is under arch/x86/kernel/cpu/ which tells you it is a *CPU* resource
control.

And also matches the user-visible "resctrl" filesystem.

But I don't have the energy to bikeshed this morning so whatever, as
long as it is short...

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.