From: tip-bot for Frederic Weisbecker <fweisbec@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com,
mingo@redhat.com, efault@gmx.de, peterz@infradead.org,
fweisbec@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perfcounters/core] perf tools: Put the show mode into the event headers files
Date: Sun, 16 Aug 2009 18:01:04 GMT [thread overview]
Message-ID: <tip-0f25bfc8d8b31a4ac8e4ff6cbc3911fb7092a4a7@git.kernel.org> (raw)
In-Reply-To: <1250445414-29237-1-git-send-email-fweisbec@gmail.com>
Commit-ID: 0f25bfc8d8b31a4ac8e4ff6cbc3911fb7092a4a7
Gitweb: http://git.kernel.org/tip/0f25bfc8d8b31a4ac8e4ff6cbc3911fb7092a4a7
Author: Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Sun, 16 Aug 2009 19:56:54 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 16 Aug 2009 19:59:13 +0200
perf tools: Put the show mode into the event headers files
Annotate and report share the same flags to filter events
considering their context (kernel, user, hypervisor).
Both tools have their own definitions of these flags. Factorize
them out into the event headers file.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1250445414-29237-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/builtin-annotate.c | 4 ----
tools/perf/builtin-report.c | 4 ----
tools/perf/util/event.h | 6 ++++++
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 820e7cc..6d75151 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -22,10 +22,6 @@
#include "util/parse-events.h"
#include "util/thread.h"
-#define SHOW_KERNEL 1
-#define SHOW_USER 2
-#define SHOW_HV 4
-
static char const *input_name = "perf.data";
static char default_sort_order[] = "comm,symbol";
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index e104ed3..05d52ff 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -27,10 +27,6 @@
#include "util/thread.h"
-#define SHOW_KERNEL 1
-#define SHOW_USER 2
-#define SHOW_HV 4
-
static char const *input_name = "perf.data";
static char default_sort_order[] = "comm,dso,symbol";
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index fa7c50b..fa2d4e9 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -4,6 +4,12 @@
#include "util.h"
#include <linux/list.h>
+enum {
+ SHOW_KERNEL = 1,
+ SHOW_USER = 2,
+ SHOW_HV = 4,
+};
+
/*
* PERF_SAMPLE_IP | PERF_SAMPLE_TID | *
*/
next prev parent reply other threads:[~2009-08-16 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 17:24 [PATCH] perf tools: Factorize the dprintf definition Frederic Weisbecker
2009-08-16 17:56 ` [PATCH] perf tools: Put the show mode into the event headers files Frederic Weisbecker
2009-08-16 18:01 ` tip-bot for Frederic Weisbecker [this message]
2009-08-16 18:00 ` [tip:perfcounters/core] perf tools: Factorize the dprintf definition tip-bot for Frederic Weisbecker
2009-08-16 18:56 ` [PATCH] perf tools: Librarize sample type and attr finding from headers Frederic Weisbecker
2009-08-16 21:10 ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
2009-08-16 20:05 ` [PATCH] perf tools: Librarize trace_event() helper Frederic Weisbecker
2009-08-16 21:10 ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0f25bfc8d8b31a4ac8e4ff6cbc3911fb7092a4a7@git.kernel.org \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox