* [tip:perf/urgent] perf tools: Fix sample type size calculation in 32 bits archs
[not found] <1306200686-17317-1-git-send-email-fweisbec@gmail.com>
@ 2011-05-24 2:51 ` tip-bot for Frederic Weisbecker
0 siblings, 0 replies; only message in thread
From: tip-bot for Frederic Weisbecker @ 2011-05-24 2:51 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, acme, hpa, mingo, eric.dumazet, a.p.zijlstra,
torvalds, fweisbec, rostedt, tglx, mingo
Commit-ID: 0f61f3e4db71946292ef8d6d6df74b8fcf001646
Gitweb: http://git.kernel.org/tip/0f61f3e4db71946292ef8d6d6df74b8fcf001646
Author: Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Tue, 24 May 2011 03:31:26 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 24 May 2011 04:33:24 +0200
perf tools: Fix sample type size calculation in 32 bits archs
The shift used here to count the number of bits set in
the mask doesn't work above the low part for archs that
are not 64 bits.
Fix the constant used for the shift.
This fixes a 32-bit perf top failure reported by Eric Dumazet:
Can't parse sample, err = -14
Can't parse sample, err = -14
...
Reported-and-tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com
Link: http://lkml.kernel.org/r/1306200686-17317-1-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/util/event.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 252b72a..6635fcd 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -42,7 +42,7 @@ int perf_sample_size(u64 sample_type)
int i;
for (i = 0; i < 64; i++) {
- if (mask & (1UL << i))
+ if (mask & (1ULL << i))
size++;
}
^ permalink raw reply related [flat|nested] only message in thread