From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089AbbHCRIm (ORCPT ); Mon, 3 Aug 2015 13:08:42 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40438 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755065AbbHCRIj (ORCPT ); Mon, 3 Aug 2015 13:08:39 -0400 Date: Mon, 3 Aug 2015 10:07:37 -0700 From: tip-bot for Konstantin Khlebnikov Message-ID: Cc: paulus@samba.org, boris.ostrovsky@oracle.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, peterz@infradead.org, agraf@suse.de, torvalds@linux-foundation.org, khlebnikov@yandex-team.ru, efault@gmx.de Reply-To: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, boris.ostrovsky@oracle.com, paulus@samba.org, efault@gmx.de, khlebnikov@yandex-team.ru, torvalds@linux-foundation.org, agraf@suse.de, peterz@infradead.org, david.vrabel@citrix.com In-Reply-To: <20150715095201.12246.49283.stgit@buzz> References: <20150715095201.12246.49283.stgit@buzz> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/preempt, xen: Use need_resched() instead of should_resched() Git-Commit-ID: 0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf Gitweb: http://git.kernel.org/tip/0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf Author: Konstantin Khlebnikov AuthorDate: Wed, 15 Jul 2015 12:52:01 +0300 Committer: Ingo Molnar CommitDate: Mon, 3 Aug 2015 12:21:23 +0200 sched/preempt, xen: Use need_resched() instead of should_resched() This code is used only when CONFIG_PREEMPT=n and only in non-atomic context: xen_in_preemptible_hcall is set only in privcmd_ioctl_hypercall(). Thus preempt_count is zero and should_resched() is equal to need_resched(). Signed-off-by: Konstantin Khlebnikov Signed-off-by: Peter Zijlstra (Intel) Cc: Alexander Graf Cc: Boris Ostrovsky Cc: David Vrabel Cc: Linus Torvalds Cc: Mike Galbraith Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20150715095201.12246.49283.stgit@buzz Signed-off-by: Ingo Molnar --- drivers/xen/preempt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/preempt.c b/drivers/xen/preempt.c index a1800c1..08cb419 100644 --- a/drivers/xen/preempt.c +++ b/drivers/xen/preempt.c @@ -31,7 +31,7 @@ EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall); asmlinkage __visible void xen_maybe_preempt_hcall(void) { if (unlikely(__this_cpu_read(xen_in_preemptible_hcall) - && should_resched())) { + && need_resched())) { /* * Clear flag as we may be rescheduled on a different * cpu.