From: tip-bot for Mike Galbraith <efault@gmx.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, efault@gmx.de, oleg@redhat.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/core] sched, autogroup: Fix reference leak
Date: Tue, 4 Jan 2011 14:19:13 GMT [thread overview]
Message-ID: <tip-101e5f77bf35679809586e250b6c62193d2ed179@git.kernel.org> (raw)
In-Reply-To: <1293784350.6839.2.camel@marge.simson.net>
Commit-ID: 101e5f77bf35679809586e250b6c62193d2ed179
Gitweb: http://git.kernel.org/tip/101e5f77bf35679809586e250b6c62193d2ed179
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Fri, 31 Dec 2010 09:32:30 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 4 Jan 2011 15:10:36 +0100
sched, autogroup: Fix reference leak
The cgroup exit mess also uncovered a struct autogroup reference leak.
copy_process() was simply freeing vs putting the signal_struct,
stranding a reference.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Oleg Nesterov <oleg@redhat.com>
LKML-Reference: <1293784350.6839.2.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/fork.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index b6f2475..0672444 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1317,7 +1317,7 @@ bad_fork_cleanup_mm:
}
bad_fork_cleanup_signal:
if (!(clone_flags & CLONE_THREAD))
- free_signal_struct(p->signal);
+ put_signal_struct(p->signal);
bad_fork_cleanup_sighand:
__cleanup_sighand(p->sighand);
bad_fork_cleanup_fs:
next prev parent reply other threads:[~2011-01-04 14:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 7:10 [PATCH] avoid race condition in pick_next_task_fair in kernel/sched_fair.c shenghui
2010-06-29 10:43 ` Peter Zijlstra
2010-06-29 11:24 ` shenghui
2010-06-29 11:35 ` Peter Zijlstra
2010-06-29 12:44 ` shenghui
2010-12-19 2:03 ` Miklos Vajna
2010-12-22 0:22 ` Miklos Vajna
2010-12-22 8:29 ` Peter Zijlstra
2010-12-22 8:41 ` Peter Zijlstra
2010-12-22 8:41 ` Mike Galbraith
2010-12-22 9:07 ` Peter Zijlstra
2010-12-22 13:31 ` Miklos Vajna
2010-12-22 14:00 ` Peter Zijlstra
2010-12-22 14:11 ` Peter Zijlstra
2010-12-22 15:14 ` Miklos Vajna
2010-12-22 15:25 ` Peter Zijlstra
2010-12-22 17:08 ` Peter Zijlstra
2010-12-22 17:16 ` Ingo Molnar
2010-12-22 17:25 ` Peter Zijlstra
2010-12-22 20:36 ` Peter Zijlstra
2010-12-23 2:08 ` Yong Zhang
2010-12-23 12:12 ` Peter Zijlstra
2010-12-23 12:33 ` Peter Zijlstra
2010-12-23 18:24 ` Peter Zijlstra
[not found] ` <1293132304.6798.6.camel@marge.simson.net>
[not found] ` <1293132862.25981.22.camel@laptop>
[not found] ` <1293187425.7138.2.camel@marge.simson.net>
[not found] ` <1293188091.25981.200.camel@laptop>
[not found] ` <1293192999.18035.4.camel@marge.simson.net>
2010-12-24 15:59 ` [PATCH] sched, cgroup: Use exit hook to avoid use-after-free crash Peter Zijlstra
2010-12-24 16:40 ` Miklos Vajna
2010-12-24 16:48 ` Mike Galbraith
2010-12-24 17:07 ` Peter Zijlstra
2010-12-24 17:24 ` Mike Galbraith
2010-12-25 17:55 ` Balbir Singh
2010-12-25 20:59 ` Paul Menage
2011-01-03 7:06 ` Peter Zijlstra
2010-12-29 15:25 ` Ingo Molnar
2010-12-29 23:07 ` Miklos Vajna
2010-12-31 10:04 ` Mike Galbraith
2010-12-31 10:46 ` Miklos Vajna
2010-12-31 8:32 ` [PATCH] " Mike Galbraith
2011-01-03 8:21 ` Peter Zijlstra
2011-01-04 14:19 ` tip-bot for Mike Galbraith [this message]
2011-01-04 14:57 ` [tip:sched/core] sched, autogroup: Fix reference leak Oleg Nesterov
2011-01-04 19:06 ` Mike Galbraith
2011-01-19 19:04 ` [tip:sched/urgent] sched, cgroup: Use exit hook to avoid use-after-free crash tip-bot for Peter Zijlstra
2010-12-22 21:11 ` [PATCH] avoid race condition in pick_next_task_fair in kernel/sched_fair.c Miklos Vajna
2010-12-22 23:39 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-101e5f77bf35679809586e250b6c62193d2ed179@git.kernel.org \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox