From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946744AbdKRIjE (ORCPT ); Sat, 18 Nov 2017 03:39:04 -0500 Received: from terminus.zytor.com ([65.50.211.136]:38261 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760983AbdKRIip (ORCPT ); Sat, 18 Nov 2017 03:38:45 -0500 Date: Sat, 18 Nov 2017 00:36:09 -0800 From: tip-bot for Kim Phillips Message-ID: Cc: tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, kim.phillips@arm.com, jolsa@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, hpa@zytor.com, acme@redhat.com, peterz@infradead.org Reply-To: acme@redhat.com, peterz@infradead.org, namhyung@kernel.org, hpa@zytor.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, kim.phillips@arm.com, tglx@linutronix.de In-Reply-To: <20171114150452.e846f2e23684c7d7d8ee706f@arm.com> References: <20171114150452.e846f2e23684c7d7d8ee706f@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf evsel: Say which PMU Hardware event doesn't support sampling/overflow-interrupts Git-Commit-ID: 114bc191c37028d87a540251d93e7b328f4de3fe X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 114bc191c37028d87a540251d93e7b328f4de3fe Gitweb: https://git.kernel.org/tip/114bc191c37028d87a540251d93e7b328f4de3fe Author: Kim Phillips AuthorDate: Tue, 14 Nov 2017 15:04:52 -0600 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 16 Nov 2017 14:50:03 -0300 perf evsel: Say which PMU Hardware event doesn't support sampling/overflow-interrupts Help identify to the user the event with the unsupported sampling error. Also suggest a corrective action. BEFORE: $ sudo ./oldperf record -e armv8_pmuv3/mem_access/,ccn/cycles/,armv8_pmuv3/l2d_cache/ true Error: PMU Hardware doesn't support sampling/overflow-interrupts. AFTER: $ sudo ./newperf record -e armv8_pmuv3/mem_access/,ccn/cycles/,armv8_pmuv3/l2d_cache/ true Error: ccn/cycles/: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' Signed-off-by: Kim Phillips Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20171114150452.e846f2e23684c7d7d8ee706f@arm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index cb9bcdb..b8e9def 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2745,8 +2745,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target, break; case EOPNOTSUPP: if (evsel->attr.sample_period != 0) - return scnprintf(msg, size, "%s", - "PMU Hardware doesn't support sampling/overflow-interrupts."); + return scnprintf(msg, size, + "%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'", + perf_evsel__name(evsel)); if (evsel->attr.precise_ip) return scnprintf(msg, size, "%s", "\'precise\' request may not be supported. Try removing 'p' modifier.");