public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, acme@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
	jolsa@redhat.com, mingo@kernel.org
Subject: [tip:perf/urgent] perf buildid-list: Requires ordered events
Date: Tue, 17 Nov 2015 22:19:00 -0800	[thread overview]
Message-ID: <tip-1216b65c502e0f130cc9984dfd5f9e1968c1eb46@git.kernel.org> (raw)
In-Reply-To: <1447408112-1920-3-git-send-email-adrian.hunter@intel.com>

Commit-ID:  1216b65c502e0f130cc9984dfd5f9e1968c1eb46
Gitweb:     http://git.kernel.org/tip/1216b65c502e0f130cc9984dfd5f9e1968c1eb46
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Fri, 13 Nov 2015 11:48:31 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 13 Nov 2015 12:22:04 -0300

perf buildid-list: Requires ordered events

'perf buildid-list' processes events to determine hits (i.e. with-hits
option).  That may not work if events are not sorted in order. i.e. MMAP
events must be processed before the samples that depend on them so that
sample processing can 'hit' the DSO to which the MMAP refers.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1447408112-1920-3-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/build-id.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index d909459..217b5a6 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -76,6 +76,7 @@ struct perf_tool build_id__mark_dso_hit_ops = {
 	.exit	= perf_event__exit_del_thread,
 	.attr		 = perf_event__process_attr,
 	.build_id	 = perf_event__process_build_id,
+	.ordered_events	 = true,
 };
 
 int build_id__sprintf(const u8 *build_id, int len, char *bf)

  reply	other threads:[~2015-11-18  6:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  9:48 [PATCH 0/3] perf tools: 3 fixes Adrian Hunter
2015-11-13  9:48 ` [PATCH 1/3] perf tools: Fix dso lookup by long name and missing buildids Adrian Hunter
2015-11-18  6:18   ` [tip:perf/urgent] perf symbols: " tip-bot for Adrian Hunter
2015-11-13  9:48 ` [PATCH 2/3] perf buildid-list: Requires ordered events Adrian Hunter
2015-11-18  6:19   ` tip-bot for Adrian Hunter [this message]
2015-11-13  9:48 ` [PATCH 3/3] perf inject: Also re-pipe lost_samples event Adrian Hunter
2015-11-18  6:19   ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2015-11-13 15:24 ` [PATCH 0/3] perf tools: 3 fixes Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1216b65c502e0f130cc9984dfd5f9e1968c1eb46@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox