From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754841AbbKRGTY (ORCPT ); Wed, 18 Nov 2015 01:19:24 -0500 Received: from terminus.zytor.com ([198.137.202.10]:50175 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754357AbbKRGTW (ORCPT ); Wed, 18 Nov 2015 01:19:22 -0500 Date: Tue, 17 Nov 2015 22:19:00 -0800 From: tip-bot for Adrian Hunter Message-ID: Cc: tglx@linutronix.de, acme@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, jolsa@redhat.com, mingo@kernel.org Reply-To: hpa@zytor.com, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, jolsa@redhat.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org In-Reply-To: <1447408112-1920-3-git-send-email-adrian.hunter@intel.com> References: <1447408112-1920-3-git-send-email-adrian.hunter@intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf buildid-list: Requires ordered events Git-Commit-ID: 1216b65c502e0f130cc9984dfd5f9e1968c1eb46 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1216b65c502e0f130cc9984dfd5f9e1968c1eb46 Gitweb: http://git.kernel.org/tip/1216b65c502e0f130cc9984dfd5f9e1968c1eb46 Author: Adrian Hunter AuthorDate: Fri, 13 Nov 2015 11:48:31 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 13 Nov 2015 12:22:04 -0300 perf buildid-list: Requires ordered events 'perf buildid-list' processes events to determine hits (i.e. with-hits option). That may not work if events are not sorted in order. i.e. MMAP events must be processed before the samples that depend on them so that sample processing can 'hit' the DSO to which the MMAP refers. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1447408112-1920-3-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/build-id.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index d909459..217b5a6 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -76,6 +76,7 @@ struct perf_tool build_id__mark_dso_hit_ops = { .exit = perf_event__exit_del_thread, .attr = perf_event__process_attr, .build_id = perf_event__process_build_id, + .ordered_events = true, }; int build_id__sprintf(const u8 *build_id, int len, char *bf)