* [PATCH] tracing: x86/fpu: Remove unused tracepoints x86_fpu_state and x86_fpu_deactivate_state
@ 2017-10-12 22:06 Steven Rostedt
2017-10-13 15:25 ` [tip:x86/fpu] x86/fpu/debug: Remove unused 'x86_fpu_state' and 'x86_fpu_deactivate_state' tracepoints tip-bot for Steven Rostedt (VMware)
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2017-10-12 22:06 UTC (permalink / raw)
To: LKML; +Cc: Thomas Gleixner, H. Peter Anvin, Ingo Molnar, x86, Dave Hansen
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Commit d1898b73 ("x86/fpu: Add tracepoints to dump FPU state at key
points") added trace points x86_fpu_state and x86_fpu_deactivate_state,
but never used them. Today they are still not used. As they take up
and waste memory, remove them.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Index: linux-trace.git/arch/x86/include/asm/trace/fpu.h
===================================================================
--- linux-trace.git.orig/arch/x86/include/asm/trace/fpu.h
+++ linux-trace.git/arch/x86/include/asm/trace/fpu.h
@@ -33,11 +33,6 @@ DECLARE_EVENT_CLASS(x86_fpu,
)
);
-DEFINE_EVENT(x86_fpu, x86_fpu_state,
- TP_PROTO(struct fpu *fpu),
- TP_ARGS(fpu)
-);
-
DEFINE_EVENT(x86_fpu, x86_fpu_before_save,
TP_PROTO(struct fpu *fpu),
TP_ARGS(fpu)
@@ -72,11 +67,6 @@ DEFINE_EVENT(x86_fpu, x86_fpu_activate_s
TP_PROTO(struct fpu *fpu),
TP_ARGS(fpu)
);
-
-DEFINE_EVENT(x86_fpu, x86_fpu_deactivate_state,
- TP_PROTO(struct fpu *fpu),
- TP_ARGS(fpu)
-);
DEFINE_EVENT(x86_fpu, x86_fpu_init_state,
TP_PROTO(struct fpu *fpu),
;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/fpu] x86/fpu/debug: Remove unused 'x86_fpu_state' and 'x86_fpu_deactivate_state' tracepoints
2017-10-12 22:06 [PATCH] tracing: x86/fpu: Remove unused tracepoints x86_fpu_state and x86_fpu_deactivate_state Steven Rostedt
@ 2017-10-13 15:25 ` tip-bot for Steven Rostedt (VMware)
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Steven Rostedt (VMware) @ 2017-10-13 15:25 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, rostedt, tglx, torvalds, peterz, dave.hansen, hpa,
mingo
Commit-ID: 127a1bea40f7f2a36bc7207ea4d51bb6b4e936fa
Gitweb: https://git.kernel.org/tip/127a1bea40f7f2a36bc7207ea4d51bb6b4e936fa
Author: Steven Rostedt (VMware) <rostedt@goodmis.org>
AuthorDate: Thu, 12 Oct 2017 18:06:19 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 13 Oct 2017 07:32:18 +0200
x86/fpu/debug: Remove unused 'x86_fpu_state' and 'x86_fpu_deactivate_state' tracepoints
Commit:
d1898b733619 ("x86/fpu: Add tracepoints to dump FPU state at key points")
... added the 'x86_fpu_state' and 'x86_fpu_deactivate_state' trace points,
but never used them. Today they are still not used. As they take up
and waste memory, remove them.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20171012180619.670b68b6@gandalf.local.home
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/trace/fpu.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/x86/include/asm/trace/fpu.h b/arch/x86/include/asm/trace/fpu.h
index 39f7a27..6b086c3 100644
--- a/arch/x86/include/asm/trace/fpu.h
+++ b/arch/x86/include/asm/trace/fpu.h
@@ -33,11 +33,6 @@ DECLARE_EVENT_CLASS(x86_fpu,
)
);
-DEFINE_EVENT(x86_fpu, x86_fpu_state,
- TP_PROTO(struct fpu *fpu),
- TP_ARGS(fpu)
-);
-
DEFINE_EVENT(x86_fpu, x86_fpu_before_save,
TP_PROTO(struct fpu *fpu),
TP_ARGS(fpu)
@@ -73,11 +68,6 @@ DEFINE_EVENT(x86_fpu, x86_fpu_activate_state,
TP_ARGS(fpu)
);
-DEFINE_EVENT(x86_fpu, x86_fpu_deactivate_state,
- TP_PROTO(struct fpu *fpu),
- TP_ARGS(fpu)
-);
-
DEFINE_EVENT(x86_fpu, x86_fpu_init_state,
TP_PROTO(struct fpu *fpu),
TP_ARGS(fpu)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 22:06 [PATCH] tracing: x86/fpu: Remove unused tracepoints x86_fpu_state and x86_fpu_deactivate_state Steven Rostedt
2017-10-13 15:25 ` [tip:x86/fpu] x86/fpu/debug: Remove unused 'x86_fpu_state' and 'x86_fpu_deactivate_state' tracepoints tip-bot for Steven Rostedt (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox