[PATCH] sched: remove noop in alloc_rt_sched_group()

[PATCH] sched: remove noop in alloc_rt_sched_group()

[Hillf Danton]

The rq varible, though computed for each possible cpu, has nothing to
do in the function, so it could be removed.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/kernel/sched.c	2011-03-30 03:09:48.000000000 +0800
+++ b/kernel/sched.c	2011-04-23 21:23:48.000000000 +0800
@@ -8539,7 +8539,6 @@ int alloc_rt_sched_group(struct task_gro
 {
 	struct rt_rq *rt_rq;
 	struct sched_rt_entity *rt_se;
-	struct rq *rq;
 	int i;

 	tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
@@ -8553,8 +8552,6 @@ int alloc_rt_sched_group(struct task_gro
 			ktime_to_ns(def_rt_bandwidth.rt_period), 0);

 	for_each_possible_cpu(i) {
-		rq = cpu_rq(i);
-
 		rt_rq = kzalloc_node(sizeof(struct rt_rq),
 				     GFP_KERNEL, cpu_to_node(i));
 		if (!rt_rq)

Re: [PATCH] sched: remove noop in alloc_rt_sched_group()

[Yong Zhang]

On Sat, Apr 23, 2011 at 09:29:05PM +0800, Hillf Danton wrote:
> The rq varible, though computed for each possible cpu, has nothing to
> do in the function, so it could be removed.
> 
> Signed-off-by: Hillf Danton <dhillf@gmail.com>

Looks good.

Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>

> ---
> 
> --- a/kernel/sched.c	2011-03-30 03:09:48.000000000 +0800
> +++ b/kernel/sched.c	2011-04-23 21:23:48.000000000 +0800
> @@ -8539,7 +8539,6 @@ int alloc_rt_sched_group(struct task_gro
>  {
>  	struct rt_rq *rt_rq;
>  	struct sched_rt_entity *rt_se;
> -	struct rq *rq;
>  	int i;
> 
>  	tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
> @@ -8553,8 +8552,6 @@ int alloc_rt_sched_group(struct task_gro
>  			ktime_to_ns(def_rt_bandwidth.rt_period), 0);
> 
>  	for_each_possible_cpu(i) {
> -		rq = cpu_rq(i);
> -
>  		rt_rq = kzalloc_node(sizeof(struct rt_rq),
>  				     GFP_KERNEL, cpu_to_node(i));
>  		if (!rt_rq)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[tip:sched/core] sched: Remove noop in alloc_rt_sched_group()

[tip-bot for Hillf Danton]

Commit-ID:  1437f5bca3c2d162f058cba37dfbeb20f619040d
Gitweb:     http://git.kernel.org/tip/1437f5bca3c2d162f058cba37dfbeb20f619040d
Author:     Hillf Danton <dhillf@gmail.com>
AuthorDate: Sat, 23 Apr 2011 21:29:05 +0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 26 Apr 2011 13:34:08 +0200

sched: Remove noop in alloc_rt_sched_group()

The rq varible, though computed for each possible cpu, has nothing to
do in the function, so it can be removed.

This also eliminates a build warning.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/BANLkTin-FfQfqW5ym1iuEmrk8s777Y1LAg@mail.gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 9cde2dd..f11a2a5 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8226,7 +8226,6 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
 {
 	struct rt_rq *rt_rq;
 	struct sched_rt_entity *rt_se;
-	struct rq *rq;
 	int i;
 
 	tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
@@ -8240,8 +8239,6 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
 			ktime_to_ns(def_rt_bandwidth.rt_period), 0);
 
 	for_each_possible_cpu(i) {
-		rq = cpu_rq(i);
-
 		rt_rq = kzalloc_node(sizeof(struct rt_rq),
 				     GFP_KERNEL, cpu_to_node(i));
 		if (!rt_rq)