From: "tip-bot for H. Peter Anvin" <hpa@linux.intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, jacob.jun.pan@linux.intel.com,
hpa@linux.intel.com
Subject: [tip:x86/mrst] x86, mrst: make mrst_timer_options an enum
Date: Wed, 19 May 2010 21:52:52 GMT [thread overview]
Message-ID: <tip-14671386dcbafb3086bbda3cb6f9f27d34c7bf6d@git.kernel.org> (raw)
In-Reply-To: <1274295685-6774-4-git-send-email-jacob.jun.pan@linux.intel.com>
Commit-ID: 14671386dcbafb3086bbda3cb6f9f27d34c7bf6d
Gitweb: http://git.kernel.org/tip/14671386dcbafb3086bbda3cb6f9f27d34c7bf6d
Author: H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Wed, 19 May 2010 14:37:40 -0700
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 19 May 2010 14:37:40 -0700
x86, mrst: make mrst_timer_options an enum
We have an enum mrst_timer_options, use it so that the kernel knows if
we're missing something from a switch statement or equivalent.
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
LKML-Reference: <1274295685-6774-4-git-send-email-jacob.jun.pan@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
arch/x86/include/asm/mrst.h | 3 ++-
arch/x86/kernel/mrst.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
index 1869c18..1635074 100644
--- a/arch/x86/include/asm/mrst.h
+++ b/arch/x86/include/asm/mrst.h
@@ -11,7 +11,6 @@
#ifndef _ASM_X86_MRST_H
#define _ASM_X86_MRST_H
extern int pci_mrst_init(void);
-extern int mrst_timer_options __cpuinitdata;
int __init sfi_parse_mrtc(struct sfi_table_header *table);
/*
@@ -38,6 +37,8 @@ enum mrst_timer_options {
MRST_TIMER_LAPIC_APBT,
};
+extern enum mrst_timer_options mrst_timer_options;
+
#define SFI_MTMR_MAX_NUM 8
#define SFI_MRTC_MAX 8
diff --git a/arch/x86/kernel/mrst.c b/arch/x86/kernel/mrst.c
index 967f268..7ee4ed9 100644
--- a/arch/x86/kernel/mrst.c
+++ b/arch/x86/kernel/mrst.c
@@ -46,7 +46,7 @@
* lapic (always-on,ARAT) ------ 150
*/
-int mrst_timer_options __cpuinitdata;
+__cpuinitdata enum mrst_timer_options mrst_timer_options;
static u32 sfi_mtimer_usage[SFI_MTMR_MAX_NUM];
static struct sfi_timer_table_entry sfi_mtimer_array[SFI_MTMR_MAX_NUM];
prev parent reply other threads:[~2010-05-19 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 19:01 [PATCH 0/3] v5 Moorestown clock related patches Jacob Pan
2010-05-19 19:01 ` [PATCH 1/3] x86: detect scattered cpuid features earlier Jacob Pan
2010-05-19 21:51 ` [tip:x86/mrst] " tip-bot for Jacob Pan
2010-05-19 19:01 ` [PATCH 2/3] x86/mrst: add cpu type detection Jacob Pan
2010-05-19 21:51 ` [tip:x86/mrst] x86, mrst: " tip-bot for Jacob Pan
2010-05-19 21:52 ` [tip:x86/mrst] x86, mrst: make mrst_identify_cpu() an inline returning enum tip-bot for H. Peter Anvin
2010-10-07 23:52 ` [tip:x86/mrst] x86, mrst: A function in a header file needs to be marked "inline" tip-bot for H. Peter Anvin
2010-05-19 19:01 ` [PATCH 3/3] x86/mrst: add more timer config options Jacob Pan
2010-05-19 21:52 ` [tip:x86/mrst] x86, mrst: " tip-bot for Jacob Pan
2010-05-19 21:52 ` tip-bot for H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-14671386dcbafb3086bbda3cb6f9f27d34c7bf6d@git.kernel.org \
--to=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).