From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbdBJKHX (ORCPT ); Fri, 10 Feb 2017 05:07:23 -0500 Received: from terminus.zytor.com ([65.50.211.136]:56920 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdBJKHS (ORCPT ); Fri, 10 Feb 2017 05:07:18 -0500 Date: Fri, 10 Feb 2017 02:07:05 -0800 From: tip-bot for Andrey Ryabinin Message-ID: Cc: mingo@kernel.org, hpa@zytor.com, paulmck@linux.vnet.ibm.com, tobias.regnery@gmail.com, glider@google.com, aryabinin@virtuozzo.com, tglx@linutronix.de, dvyukov@google.com, linux-kernel@vger.kernel.org Reply-To: linux-kernel@vger.kernel.org, dvyukov@google.com, tglx@linutronix.de, aryabinin@virtuozzo.com, glider@google.com, paulmck@linux.vnet.ibm.com, tobias.regnery@gmail.com, hpa@zytor.com, mingo@kernel.org In-Reply-To: <20170210095405.31802-1-aryabinin@virtuozzo.com> References: <20170210095405.31802-1-aryabinin@virtuozzo.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/mm/ptdump: Fix soft lockup in page table walker Git-Commit-ID: 146fbb766934dc003fcbf755b519acef683576bf X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 146fbb766934dc003fcbf755b519acef683576bf Gitweb: http://git.kernel.org/tip/146fbb766934dc003fcbf755b519acef683576bf Author: Andrey Ryabinin AuthorDate: Fri, 10 Feb 2017 12:54:05 +0300 Committer: Thomas Gleixner CommitDate: Fri, 10 Feb 2017 11:00:23 +0100 x86/mm/ptdump: Fix soft lockup in page table walker CONFIG_KASAN=y needs a lot of virtual memory mapped for its shadow. In that case ptdump_walk_pgd_level_core() takes a lot of time to walk across all page tables and doing this without a rescheduling causes soft lockups: NMI watchdog: BUG: soft lockup - CPU#3 stuck for 23s! [swapper/0:1] ... Call Trace: ptdump_walk_pgd_level_core+0x40c/0x550 ptdump_walk_pgd_level_checkwx+0x17/0x20 mark_rodata_ro+0x13b/0x150 kernel_init+0x2f/0x120 ret_from_fork+0x2c/0x40 I guess that this issue might arise even without KASAN on huge machines with several terabytes of RAM. Stick cond_resched() in pgd loop to fix this. Reported-by: Tobias Regnery Signed-off-by: Andrey Ryabinin Cc: kasan-dev@googlegroups.com Cc: Alexander Potapenko Cc: "Paul E . McKenney" Cc: Dmitry Vyukov Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20170210095405.31802-1-aryabinin@virtuozzo.com Signed-off-by: Thomas Gleixner --- arch/x86/mm/dump_pagetables.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index ea9c49a..8aa6bea 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -406,6 +407,7 @@ static void ptdump_walk_pgd_level_core(struct seq_file *m, pgd_t *pgd, } else note_page(m, &st, __pgprot(0), 1); + cond_resched(); start++; }