From: tip-bot for Borislav Petkov <borislav.petkov@amd.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hans.rosenfeld@amd.com,
Boris.Ostrovsky@amd.com, nbowler@elliptictech.com, hpa@zytor.com,
mingo@redhat.com, andreas.herrmann3@amd.com, greg@kroah.com,
jvpeetz@web.de, tglx@linutronix.de, mingo@elte.hu,
borislav.petkov@amd.com
Subject: [tip:x86/urgent] x86, AMD: Fix ARAT feature setting again
Date: Tue, 17 May 2011 13:47:00 GMT [thread overview]
Message-ID: <tip-14fb57dccb6e1defe9f89a66f548fcb24c374c1d@git.kernel.org> (raw)
In-Reply-To: <1305636919-31165-3-git-send-email-bp@amd64.org>
Commit-ID: 14fb57dccb6e1defe9f89a66f548fcb24c374c1d
Gitweb: http://git.kernel.org/tip/14fb57dccb6e1defe9f89a66f548fcb24c374c1d
Author: Borislav Petkov <borislav.petkov@amd.com>
AuthorDate: Tue, 17 May 2011 14:55:19 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 17 May 2011 15:28:34 +0200
x86, AMD: Fix ARAT feature setting again
Trying to enable the local APIC timer on early K8 revisions
uncovers a number of other issues with it, in conjunction with
the C1E enter path on AMD. Fixing those causes much more churn
and troubles than the benefit of using that timer brings so
don't enable it on K8 at all, falling back to the original
functionality the kernel had wrt to that.
Reported-and-bisected-by: Nick Bowler <nbowler@elliptictech.com>
Cc: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>
Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>
Cc: Nick Bowler <nbowler@elliptictech.com>
Cc: Joerg-Volker-Peetz <jvpeetz@web.de>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Link: http://lkml.kernel.org/r/1305636919-31165-3-git-send-email-bp@amd64.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/amd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..6f9d1f6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,7 +613,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
#endif
/* As a rule processors have APIC timer running in deep C states */
- if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+ if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
set_cpu_cap(c, X86_FEATURE_ARAT);
/*
next prev parent reply other threads:[~2011-05-17 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:55 [PATCH 0/2] AMD ARAT fixes Borislav Petkov
2011-05-17 12:55 ` [PATCH 1/2] Revert "x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors" Borislav Petkov
2011-05-17 12:55 ` [PATCH 2/2] x86, AMD: Fix ARAT feature setting again Borislav Petkov
2011-05-17 13:47 ` tip-bot for Borislav Petkov [this message]
2011-05-17 16:38 ` [PATCH 0/2] AMD ARAT fixes Jörg-Volker Peetz
2011-05-17 16:53 ` Borislav Petkov
2011-05-17 17:21 ` Jörg-Volker Peetz
2011-05-17 17:46 ` Borislav Petkov
2011-05-17 17:51 ` Jörg-Volker Peetz
2011-05-17 18:01 ` Borislav Petkov
2011-05-17 22:30 ` Nick Bowler
2011-05-18 6:51 ` Borislav Petkov
2011-05-18 15:50 ` Borislav Petkov
2011-05-20 14:37 ` Chuck Ebbert
2011-05-20 18:10 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-14fb57dccb6e1defe9f89a66f548fcb24c374c1d@git.kernel.org \
--to=borislav.petkov@amd.com \
--cc=Boris.Ostrovsky@amd.com \
--cc=andreas.herrmann3@amd.com \
--cc=greg@kroah.com \
--cc=hans.rosenfeld@amd.com \
--cc=hpa@zytor.com \
--cc=jvpeetz@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=nbowler@elliptictech.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).