public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Feng Tang <feng.tang@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
	mingo@kernel.org, andi@firstfloor.org, a.p.zijlstra@chello.nl,
	namhyung@kernel.org, dsahern@gmail.com, tglx@linutronix.de,
	feng.tang@intel.com, mingo@elte.hu
Subject: [tip:perf/core] perf symbols: Filter samples with unresolved symbol when "--symbols" option is used
Date: Wed, 19 Sep 2012 08:21:21 -0700	[thread overview]
Message-ID: <tip-1500b93b61fc70a1176871b64f1c8ae3bd4da9dd@git.kernel.org> (raw)
In-Reply-To: <1347007349-3102-2-git-send-email-feng.tang@intel.com>

Commit-ID:  1500b93b61fc70a1176871b64f1c8ae3bd4da9dd
Gitweb:     http://git.kernel.org/tip/1500b93b61fc70a1176871b64f1c8ae3bd4da9dd
Author:     Feng Tang <feng.tang@intel.com>
AuthorDate: Fri, 7 Sep 2012 16:42:23 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 17 Sep 2012 13:10:57 -0300

perf symbols: Filter samples with unresolved symbol when "--symbols" option is used

Report/top commands support to only handle specific symbols with
"--symbols" option, but current code will keep those samples whose
symbol can't be resolved, which should actually be filtered.

If we run following commands:
$perf record -a tree
$perf report --symbols intel_idle -n
the output will be:

Without the patch:
==================
    46.27%        156     sshd  [unknown]
    26.05%         48  swapper  [kernel.kallsyms]
    17.26%         38     tree  libc-2.12.1.so
     7.69%         17     tree  tree
     2.73%          6     tree  ld-2.12.1.so

With the patch:
===============
   100.00%         48  swapper  [kernel.kallsyms]

Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1347007349-3102-2-git-send-email-feng.tang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 8202f5c..6715b19 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -904,8 +904,9 @@ int perf_event__preprocess_sample(const union perf_event *event,
 		al->sym = map__find_symbol(al->map, al->addr, filter);
 	}
 
-	if (symbol_conf.sym_list && al->sym &&
-	    !strlist__has_entry(symbol_conf.sym_list, al->sym->name))
+	if (symbol_conf.sym_list &&
+		(!al->sym || !strlist__has_entry(symbol_conf.sym_list,
+						al->sym->name)))
 		goto out_filtered;
 
 	return 0;

  reply	other threads:[~2012-09-19 15:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07  8:42 [PATCH v2 0/7] perf ui/browser: Add browser for perf script Feng Tang
2012-09-07  8:42 ` [PATCH v2 1/7] perf symbols: Filter samples with unresolved symbol when "--symbols" option is used Feng Tang
2012-09-19 15:21   ` tip-bot for Feng Tang [this message]
2012-09-07  8:42 ` [PATCH v2 2/7] perf scripts: Add --symbols option to handle specific symbols Feng Tang
2012-09-19 15:22   ` [tip:perf/core] " tip-bot for Feng Tang
2012-09-07  8:42 ` [PATCH v2 3/7] perf scripts: Add event_analyzing_sample-record/report Feng Tang
2012-09-19 15:23   ` [tip:perf/core] perf scripts: Add event_analyzing_sample-record/ report tip-bot for Feng Tang
2012-09-07  8:42 ` [PATCH v2 4/7] perf scripts: Export a find_scripts() function Feng Tang
2012-09-19 15:24   ` [tip:perf/core] " tip-bot for Feng Tang
2012-09-07  8:42 ` [PATCH v2 5/7] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-07  8:42 ` [PATCH v2 6/7] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-09-17 15:23   ` Arnaldo Carvalho de Melo
2012-09-18  7:40     ` Feng Tang
2012-09-18 11:30       ` Arnaldo Carvalho de Melo
2012-09-18 15:56         ` Feng Tang
2012-09-07  8:42 ` [PATCH v2 7/7] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-10  1:35 ` [PATCH v2 0/7] perf ui/browser: Add browser for perf script Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1500b93b61fc70a1176871b64f1c8ae3bd4da9dd@git.kernel.org \
    --to=feng.tang@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox