From: tip-bot for Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
mingo@redhat.com, a.p.zijlstra@chello.nl,
mitake@dcl.info.waseda.ac.jp, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/bench] perf bench: Modify builtin-pipe.c for processing common options
Date: Tue, 10 Nov 2009 04:22:52 GMT [thread overview]
Message-ID: <tip-158ba827f6deef4102c5247ed4b6a587f0bd6a07@git.kernel.org> (raw)
In-Reply-To: <1257808802-9420-5-git-send-email-mitake@dcl.info.waseda.ac.jp>
Commit-ID: 158ba827f6deef4102c5247ed4b6a587f0bd6a07
Gitweb: http://git.kernel.org/tip/158ba827f6deef4102c5247ed4b6a587f0bd6a07
Author: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
AuthorDate: Tue, 10 Nov 2009 08:20:02 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 10 Nov 2009 04:53:49 +0100
perf bench: Modify builtin-pipe.c for processing common options
This patch modifies builtin-pipe.c for processing common
options. The first option added is "--format".
Users of perf bench will be able to specify output style by
--format.
Usage example:
% ./perf bench sched pipe # with no style specify
(executing 1000000 pipe operations between two tasks)
Total time:5.855 sec
5.855061 usecs/op
170792 ops/sec
% ./perf bench --format=simple sched pipe # specified simple
5.988
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1257808802-9420-5-git-send-email-mitake@dcl.info.waseda.ac.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
---
tools/perf/bench/sched-pipe.c | 22 ++++++++++++++--------
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c
index 6a29100..a9ac186 100644
--- a/tools/perf/bench/sched-pipe.c
+++ b/tools/perf/bench/sched-pipe.c
@@ -30,14 +30,10 @@
#define LOOPS_DEFAULT 1000000
static int loops = LOOPS_DEFAULT;
-static int simple = 0;
static const struct option options[] = {
OPT_INTEGER('l', "loop", &loops,
"Specify number of loops"),
- OPT_BOOLEAN('s', "simple-output", &simple,
- "Do simple output (this maybe useful for"
- "processing by scripts or graph tools like gnuplot)"),
OPT_END()
};
@@ -94,10 +90,8 @@ int bench_sched_pipe(int argc, const char **argv,
return 0;
}
- if (simple)
- printf("%lu.%03lu\n",
- diff.tv_sec, diff.tv_usec / 1000);
- else {
+ switch (bench_format) {
+ case BENCH_FORMAT_DEFAULT:
printf("(executing %d pipe operations between two tasks)\n\n",
loops);
@@ -111,6 +105,18 @@ int bench_sched_pipe(int argc, const char **argv,
printf("\t\t%d ops/sec\n",
(int)((double)loops /
((double)result_usec / (double)1000000)));
+ break;
+
+ case BENCH_FORMAT_SIMPLE:
+ printf("%lu.%03lu\n",
+ diff.tv_sec, diff.tv_usec / 1000);
+ break;
+
+ default:
+ /* reaching here is something disaster */
+ fprintf(stderr, "Unknown format:%d\n", bench_format);
+ exit(1);
+ break;
}
return 0;
next prev parent reply other threads:[~2009-11-10 4:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 23:19 [PATCH v2 0/4] perf bench: Common option for specifying style formatting Hitoshi Mitake
2009-11-09 23:19 ` [PATCH v2 1/4] perf bench: Add stuffs to bench.h for unified output formatting Hitoshi Mitake
2009-11-10 4:22 ` [tip:perf/bench] perf bench: Add format constants " tip-bot for Hitoshi Mitake
2009-11-09 23:20 ` [PATCH v2 2/4] perf bench: Modify builtin-bench.c for processing common options Hitoshi Mitake
2009-11-10 4:22 ` [tip:perf/bench] " tip-bot for Hitoshi Mitake
2009-11-09 23:20 ` [PATCH v2 3/4] perf bench: Modified bench/bench-messaging.c to adopt unified output formatting Hitoshi Mitake
2009-11-10 4:22 ` [tip:perf/bench] perf bench: Modify " tip-bot for Hitoshi Mitake
2009-11-09 23:20 ` [PATCH v2 4/4] perf bench: Modify builtin-pipe.c for processing common options Hitoshi Mitake
2009-11-10 4:22 ` tip-bot for Hitoshi Mitake [this message]
2009-11-10 3:58 ` [PATCH v2 0/4] perf bench: Common option for specifying style formatting Ingo Molnar
2009-11-10 7:51 ` Hitoshi Mitake
2009-11-10 8:01 ` Ingo Molnar
2009-11-10 8:23 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-158ba827f6deef4102c5247ed4b6a587f0bd6a07@git.kernel.org \
--to=mitake@dcl.info.waseda.ac.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox