* [PATCH] perf tools: consider header files outside perf directory in tags target
@ 2014-05-27 16:23 Sebastian Andrzej Siewior
2014-05-27 16:33 ` Jiri Olsa
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2014-05-27 16:23 UTC (permalink / raw)
To: linux-kernel
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Sebastian Andrzej Siewior
This fixes lookups like "vi -t event_format"
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
tools/perf/Makefile.perf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 895edd3..8148992 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -812,15 +812,15 @@ INSTALL_DOC_TARGETS += quick-install-doc quick-install-man quick-install-html
TAGS:
$(RM) TAGS
- $(FIND) . -name '*.[hcS]' -print | xargs etags -a
+ $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs etags -a ../../include/uapi/linux/perf_event.h
tags:
$(RM) tags
- $(FIND) . -name '*.[hcS]' -print | xargs ctags -a
+ $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs ctags -a ../../include/uapi/linux/perf_event.h
cscope:
$(RM) cscope*
- $(FIND) . -name '*.[hcS]' -print | xargs cscope -b
+ $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs cscope -b ../../include/uapi/linux/perf_event.h
### Detect prefix changes
TRACK_CFLAGS = $(subst ','\'',$(CFLAGS)):\
--
2.0.0.rc4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf tools: consider header files outside perf directory in tags target
2014-05-27 16:23 [PATCH] perf tools: consider header files outside perf directory in tags target Sebastian Andrzej Siewior
@ 2014-05-27 16:33 ` Jiri Olsa
2014-05-28 8:19 ` [PATCH v2] " Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2014-05-27 16:33 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, Arnaldo Carvalho de Melo, Jiri Olsa
On Tue, May 27, 2014 at 06:23:42PM +0200, Sebastian Andrzej Siewior wrote:
> This fixes lookups like "vi -t event_format"
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> tools/perf/Makefile.perf | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 895edd3..8148992 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -812,15 +812,15 @@ INSTALL_DOC_TARGETS += quick-install-doc quick-install-man quick-install-html
>
> TAGS:
> $(RM) TAGS
> - $(FIND) . -name '*.[hcS]' -print | xargs etags -a
> + $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs etags -a ../../include/uapi/linux/perf_event.h
>
> tags:
> $(RM) tags
> - $(FIND) . -name '*.[hcS]' -print | xargs ctags -a
> + $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs ctags -a ../../include/uapi/linux/perf_event.h
>
> cscope:
> $(RM) cscope*
> - $(FIND) . -name '*.[hcS]' -print | xargs cscope -b
> + $(FIND) . ../lib/traceevent -name '*.[hcS]' -print | xargs cscope -b ../../include/uapi/linux/perf_event.h
while you are at it, could you please also include:
../lib/api/
../lib/symbol/
also given that same paths are used on multiple places,
please put them into variable
thanks,
jirka
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] perf tools: consider header files outside perf directory in tags target
2014-05-27 16:33 ` Jiri Olsa
@ 2014-05-28 8:19 ` Sebastian Andrzej Siewior
2014-06-05 14:31 ` [tip:perf/core] perf tools: Consider " tip-bot for Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2014-05-28 8:19 UTC (permalink / raw)
To: Jiri Olsa; +Cc: linux-kernel, Arnaldo Carvalho de Melo
This fixes lookups like "vi -t event_format"
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
v1..v2:
- add ../lib/{api|symbol}
- move the files & folders into a variable which can be resued for
the three users.
tools/perf/Makefile.perf | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 895edd3..90e96ea 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -810,17 +810,20 @@ INSTALL_DOC_TARGETS += quick-install-doc quick-install-man quick-install-html
$(DOC_TARGETS):
$(QUIET_SUBDIR0)Documentation $(QUIET_SUBDIR1) $(@:doc=all)
+TAG_FOLDERS= . ../lib/traceevent ../lib/api ../lib/symbol
+TAG_FILES= ../../include/uapi/linux/perf_event.h
+
TAGS:
$(RM) TAGS
- $(FIND) . -name '*.[hcS]' -print | xargs etags -a
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs etags -a $(TAG_FILES)
tags:
$(RM) tags
- $(FIND) . -name '*.[hcS]' -print | xargs ctags -a
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs ctags -a $(TAG_FILES)
cscope:
$(RM) cscope*
- $(FIND) . -name '*.[hcS]' -print | xargs cscope -b
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs cscope -b $(TAG_FILES)
### Detect prefix changes
TRACK_CFLAGS = $(subst ','\'',$(CFLAGS)):\
--
2.0.0.rc4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:perf/core] perf tools: Consider header files outside perf directory in tags target
2014-05-28 8:19 ` [PATCH v2] " Sebastian Andrzej Siewior
@ 2014-06-05 14:31 ` tip-bot for Sebastian Andrzej Siewior
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Sebastian Andrzej Siewior @ 2014-06-05 14:31 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, jolsa, bigeasy, tglx
Commit-ID: 16a6433615c14097fd8d406b10ce6393aebb7017
Gitweb: http://git.kernel.org/tip/16a6433615c14097fd8d406b10ce6393aebb7017
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate: Wed, 28 May 2014 10:19:18 +0200
Committer: Jiri Olsa <jolsa@kernel.org>
CommitDate: Tue, 3 Jun 2014 21:34:23 +0200
perf tools: Consider header files outside perf directory in tags target
This fixes lookups like "vi -t event_format"
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: http://lkml.kernel.org/r/20140528081918.GA28567@linutronix.de
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/Makefile.perf | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 67f7c05..6286e13 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -815,17 +815,20 @@ INSTALL_DOC_TARGETS += quick-install-doc quick-install-man quick-install-html
$(DOC_TARGETS):
$(QUIET_SUBDIR0)Documentation $(QUIET_SUBDIR1) $(@:doc=all)
+TAG_FOLDERS= . ../lib/traceevent ../lib/api ../lib/symbol
+TAG_FILES= ../../include/uapi/linux/perf_event.h
+
TAGS:
$(RM) TAGS
- $(FIND) . -name '*.[hcS]' -print | xargs etags -a
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs etags -a $(TAG_FILES)
tags:
$(RM) tags
- $(FIND) . -name '*.[hcS]' -print | xargs ctags -a
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs ctags -a $(TAG_FILES)
cscope:
$(RM) cscope*
- $(FIND) . -name '*.[hcS]' -print | xargs cscope -b
+ $(FIND) $(TAG_FOLDERS) -name '*.[hcS]' -print | xargs cscope -b $(TAG_FILES)
### Detect prefix changes
TRACK_CFLAGS = $(subst ','\'',$(CFLAGS)):\
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-05 14:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27 16:23 [PATCH] perf tools: consider header files outside perf directory in tags target Sebastian Andrzej Siewior
2014-05-27 16:33 ` Jiri Olsa
2014-05-28 8:19 ` [PATCH v2] " Sebastian Andrzej Siewior
2014-06-05 14:31 ` [tip:perf/core] perf tools: Consider " tip-bot for Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).