From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2E9C10F0E for ; Thu, 18 Apr 2019 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C46D9217D7 for ; Thu, 18 Apr 2019 12:25:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="i4CKXznP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388971AbfDRMZe (ORCPT ); Thu, 18 Apr 2019 08:25:34 -0400 Received: from terminus.zytor.com ([198.137.202.136]:54995 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727807AbfDRMZd (ORCPT ); Thu, 18 Apr 2019 08:25:33 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3ICPCWw186544 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 18 Apr 2019 05:25:12 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3ICPCWw186544 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1555590313; bh=sYkGGqOokipR0ipqe9HlUUUuKPW3ewY02sCP2jcnO6M=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=i4CKXznPV7BOKUauZ3NMlUUdsORWz7WxJof1eId8XCDA6XTlus3+/EjKTleUoDGfe X5vJYfNC0r6hB6MrfGPPuuCfmtuOTLPBYbvBGAOWERbmjuVxMr9q3kBEZAULFM2I9Y Wl2q2thQ8pXqY4KE0xzYHeAKH8iaMq12YdNyt/dbLkuh9SGlIrBq1pE1vuZmbPAUpV S8LAYAsXlbEEHJsudflesWsjE4Tz+woJrgvuM5+kqdYqXG0tlVfw2bWRqVwdwN9HgP ka4rtvSTKbrqxIec2sCLq7s6ulrq+XGLp/s7663gbIOKijt9IThkLt5qWU0uAaxcqz 96AvGkl9YeNQw== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3ICPBD5186541; Thu, 18 Apr 2019 05:25:11 -0700 Date: Thu, 18 Apr 2019 05:25:11 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for YueHaibing Message-ID: Cc: hpa@zytor.com, peterz@infradead.org, yuehaibing@huawei.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org Reply-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, hpa@zytor.com, peterz@infradead.org, yuehaibing@huawei.com In-Reply-To: <20190322143153.14416-1-yuehaibing@huawei.com> References: <20190322143153.14416-1-yuehaibing@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/core: Make some functions static Git-Commit-ID: 16e671afb70f28eb189136d1395c59dafecd270a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 16e671afb70f28eb189136d1395c59dafecd270a Gitweb: https://git.kernel.org/tip/16e671afb70f28eb189136d1395c59dafecd270a Author: YueHaibing AuthorDate: Fri, 22 Mar 2019 22:31:53 +0800 Committer: Ingo Molnar CommitDate: Thu, 18 Apr 2019 14:19:25 +0200 sched/core: Make some functions static Fix these sparse warnings: kernel/sched/core.c:6576:11: warning: symbol 'max_cfs_quota_period' was not declared. Should it be static? kernel/sched/core.c:6577:11: warning: symbol 'min_cfs_quota_period' was not declared. Should it be static? kernel/sched/core.c:6657:5: warning: symbol 'tg_set_cfs_quota' was not declared. Should it be static? kernel/sched/core.c:6670:6: warning: symbol 'tg_get_cfs_quota' was not declared. Should it be static? kernel/sched/core.c:6683:5: warning: symbol 'tg_set_cfs_period' was not declared. Should it be static? kernel/sched/core.c:6693:6: warning: symbol 'tg_get_cfs_period' was not declared. Should it be static? kernel/sched/fair.c:2596:6: warning: symbol 'task_tick_numa' was not declared. Should it be static? Signed-off-by: YueHaibing Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20190322143153.14416-1-yuehaibing@huawei.com Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 12 ++++++------ kernel/sched/fair.c | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index f4838b78b9f9..7f2a5fd316f8 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6521,8 +6521,8 @@ static u64 cpu_shares_read_u64(struct cgroup_subsys_state *css, #ifdef CONFIG_CFS_BANDWIDTH static DEFINE_MUTEX(cfs_constraints_mutex); -const u64 max_cfs_quota_period = 1 * NSEC_PER_SEC; /* 1s */ -const u64 min_cfs_quota_period = 1 * NSEC_PER_MSEC; /* 1ms */ +static const u64 max_cfs_quota_period = 1 * NSEC_PER_SEC; /* 1s */ +static const u64 min_cfs_quota_period = 1 * NSEC_PER_MSEC; /* 1ms */ static int __cfs_schedulable(struct task_group *tg, u64 period, u64 runtime); @@ -6602,7 +6602,7 @@ out_unlock: return ret; } -int tg_set_cfs_quota(struct task_group *tg, long cfs_quota_us) +static int tg_set_cfs_quota(struct task_group *tg, long cfs_quota_us) { u64 quota, period; @@ -6615,7 +6615,7 @@ int tg_set_cfs_quota(struct task_group *tg, long cfs_quota_us) return tg_set_cfs_bandwidth(tg, period, quota); } -long tg_get_cfs_quota(struct task_group *tg) +static long tg_get_cfs_quota(struct task_group *tg) { u64 quota_us; @@ -6628,7 +6628,7 @@ long tg_get_cfs_quota(struct task_group *tg) return quota_us; } -int tg_set_cfs_period(struct task_group *tg, long cfs_period_us) +static int tg_set_cfs_period(struct task_group *tg, long cfs_period_us) { u64 quota, period; @@ -6638,7 +6638,7 @@ int tg_set_cfs_period(struct task_group *tg, long cfs_period_us) return tg_set_cfs_bandwidth(tg, period, quota); } -long tg_get_cfs_period(struct task_group *tg) +static long tg_get_cfs_period(struct task_group *tg) { u64 cfs_period_us; diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e5b100b6ba4e..13bafe350abf 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2593,7 +2593,7 @@ out: /* * Drive the periodic memory faults.. */ -void task_tick_numa(struct rq *rq, struct task_struct *curr) +static void task_tick_numa(struct rq *rq, struct task_struct *curr) { struct callback_head *work = &curr->numa_work; u64 period, now;