public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Marc Zyngier <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: chris@zankel.net, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, james.hogan@imgtec.com,
	tglx@linutronix.de, marc.zyngier@arm.com, hpa@zytor.com,
	mingo@kernel.org, sebastian.hesselbarth@gmail.com,
	jason@lakedaemon.net, jcmvbkbc@gmail.com, cernekee@gmail.com,
	matt.redfearn@imgtec.com, xuwei5@hisilicon.com, andrew@lunn.ch,
	gregory.clement@free-electrons.com, paul.burton@imgtec.com
Subject: [tip:irq/core] irqchip/mips-gic: Report that effective affinity is a single target
Date: Fri, 18 Aug 2017 02:01:34 -0700	[thread overview]
Message-ID: <tip-18416e45b76189daf37ba53b2bd0b9ac3749e92e@git.kernel.org> (raw)
In-Reply-To: <20170818083925.10108-12-marc.zyngier@arm.com>

Commit-ID:  18416e45b76189daf37ba53b2bd0b9ac3749e92e
Gitweb:     http://git.kernel.org/tip/18416e45b76189daf37ba53b2bd0b9ac3749e92e
Author:     Marc Zyngier <marc.zyngier@arm.com>
AuthorDate: Fri, 18 Aug 2017 09:39:24 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 18 Aug 2017 10:54:43 +0200

irqchip/mips-gic: Report that effective affinity is a single target

The MIPS GIC driver only targets a single CPU at a time, even if
the notional affinity is wider. Let's inform the core code
about this.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Link: http://lkml.kernel.org/r/20170818083925.10108-12-marc.zyngier@arm.com

---
 drivers/irqchip/Kconfig        |  1 +
 drivers/irqchip/irq-mips-gic.c | 10 +++++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 39bfa5b..bca9a88 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -141,6 +141,7 @@ config IRQ_MIPS_CPU
 	select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
+	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
 
 config CLPS711X_IRQCHIP
 	bool
diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index 6ab1d3a..6461380 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -445,24 +445,27 @@ static int gic_set_affinity(struct irq_data *d, const struct cpumask *cpumask,
 	unsigned int irq = GIC_HWIRQ_TO_SHARED(d->hwirq);
 	cpumask_t	tmp = CPU_MASK_NONE;
 	unsigned long	flags;
-	int		i;
+	int		i, cpu;
 
 	cpumask_and(&tmp, cpumask, cpu_online_mask);
 	if (cpumask_empty(&tmp))
 		return -EINVAL;
 
+	cpu = cpumask_first(&tmp);
+
 	/* Assumption : cpumask refers to a single CPU */
 	spin_lock_irqsave(&gic_lock, flags);
 
 	/* Re-route this IRQ */
-	gic_map_to_vpe(irq, mips_cm_vp_id(cpumask_first(&tmp)));
+	gic_map_to_vpe(irq, mips_cm_vp_id(cpu));
 
 	/* Update the pcpu_masks */
 	for (i = 0; i < min(gic_vpes, NR_CPUS); i++)
 		clear_bit(irq, pcpu_masks[i].pcpu_mask);
-	set_bit(irq, pcpu_masks[cpumask_first(&tmp)].pcpu_mask);
+	set_bit(irq, pcpu_masks[cpu].pcpu_mask);
 
 	cpumask_copy(irq_data_get_affinity_mask(d), cpumask);
+	irq_data_update_effective_affinity(d, cpumask_of(cpu));
 	spin_unlock_irqrestore(&gic_lock, flags);
 
 	return IRQ_SET_MASK_OK_NOCOPY;
@@ -716,6 +719,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq,
 		if (err)
 			return err;
 
+		irqd_set_single_target(irq_desc_get_irq_data(irq_to_desc(virq)));
 		return gic_shared_irq_domain_map(d, virq, hwirq, 0);
 	}
 

  reply	other threads:[~2017-08-18  9:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  8:39 [PATCH v2 00/12] genirq/irqchip: Effective affinity fixups Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 01/12] genirq: Restrict effective affinity to interrupts actually using it Marc Zyngier
2017-08-18  8:57   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 02/12] genirq/proc: Use the the accessor to report the effective affinity Marc Zyngier
2017-08-18  8:58   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 03/12] irqchip/gic: Report that effective affinity is a single target Marc Zyngier
2017-08-18  8:58   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 04/12] irqchip/gic-v3: " Marc Zyngier
2017-08-18  8:58   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 05/12] irqchip/gic-v3-its: " Marc Zyngier
2017-08-18  8:59   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 06/12] irqchip/armada-370-xp: " Marc Zyngier
2017-08-18  8:59   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 07/12] irqchip/bcm-6345-l1: " Marc Zyngier
2017-08-18  9:00   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 08/12] irqchip/bcm-7038-l1: " Marc Zyngier
2017-08-18  9:00   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 09/12] irqchip/metag-ext: " Marc Zyngier
2017-08-18  9:00   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 10/12] irqchip/hip04: " Marc Zyngier
2017-08-18  9:01   ` [tip:irq/core] " tip-bot for Marc Zyngier
2017-08-18  8:39 ` [PATCH v2 11/12] irqchip/mips-gic: " Marc Zyngier
2017-08-18  9:01   ` tip-bot for Marc Zyngier [this message]
2017-08-18  8:39 ` [PATCH v2 12/12] irqchip/xtensa-mx: " Marc Zyngier
2017-08-18  9:01   ` [tip:irq/core] " tip-bot for Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-18416e45b76189daf37ba53b2bd0b9ac3749e92e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=andrew@lunn.ch \
    --cc=cernekee@gmail.com \
    --cc=chris@zankel.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=hpa@zytor.com \
    --cc=james.hogan@imgtec.com \
    --cc=jason@lakedaemon.net \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=matt.redfearn@imgtec.com \
    --cc=mingo@kernel.org \
    --cc=paul.burton@imgtec.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox