From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbcBWJDk (ORCPT ); Tue, 23 Feb 2016 04:03:40 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57170 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbcBWJDa (ORCPT ); Tue, 23 Feb 2016 04:03:30 -0500 Date: Tue, 23 Feb 2016 00:59:24 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com Message-ID: Cc: chris.j.arges@canonical.com, namhyung@gmail.com, luto@amacapital.net, mmarek@suse.cz, brgerst@gmail.com, torvalds@linux-foundation.org, palves@redhat.com, tglx@linutronix.de, jpoimboe@redhat.com, acme@kernel.org, luto@kernel.org, hpa@zytor.com, mingo@kernel.org, dvlasenk@redhat.com, bernd@petrovitsch.priv.at, jslaby@suse.cz, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, peterz@infradead.org, bp@alien8.de Reply-To: bp@alien8.de, akpm@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jslaby@suse.cz, dvlasenk@redhat.com, bernd@petrovitsch.priv.at, hpa@zytor.com, mingo@kernel.org, luto@kernel.org, acme@kernel.org, jpoimboe@redhat.com, torvalds@linux-foundation.org, palves@redhat.com, tglx@linutronix.de, brgerst@gmail.com, mmarek@suse.cz, namhyung@gmail.com, luto@amacapital.net, chris.j.arges@canonical.com In-Reply-To: <15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com> References: <15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com> To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHg4Ni9hc20vY3J5cHRvOiBEb24ndCB1c2UgUkJQIGE=?= =?UTF-8?B?cyBhIHNjcmF0Y2ggcmVnaXN0ZXI=?= Git-Commit-ID: =?UTF-8?B?MWJkMDNjZjU3YTliMmUyMjk0MTQzZjc2YzIxZjM4NmE5NGU1ZTZjOA==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1bd03cf57a9b2e2294143f76c21f386a94e5e6c8 Gitweb: http://git.kernel.org/tip/1bd03cf57a9b2e2294143f76c21f386a94e5e6c8 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:18 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:57 +0100 x86/asm/crypto: Don't use RBP as a scratch register The frame pointer (RBP) is getting clobbered in sha1_mb_mgr_submit_avx2() before a function call, which can mess up stack traces. Use R12 instead. Signed-off-by: Josh Poimboeuf Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S index a5a14c6..c3b9447 100644 --- a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S +++ b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S @@ -86,8 +86,8 @@ job_rax = %rax len = %rax DWORD_len = %eax -lane = %rbp -tmp3 = %rbp +lane = %r12 +tmp3 = %r12 tmp = %r9 DWORD_tmp = %r9d @@ -99,7 +99,7 @@ lane_data = %r10 # arg 2 : rdx : job ENTRY(sha1_mb_mgr_submit_avx2) push %rbx - push %rbp + push %r12 mov _unused_lanes(state), unused_lanes mov unused_lanes, lane @@ -190,7 +190,7 @@ len_is_0: movl DWORD_tmp, _result_digest+1*16(job_rax) return: - pop %rbp + pop %r12 pop %rbx ret