From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, jolsa@redhat.com, acme@redhat.com,
mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
adrian.hunter@intel.com
Subject: [tip:perf/core] perf intel-pt: Fix error recovery from missing TIP packet
Date: Fri, 9 Mar 2018 00:48:19 -0800 [thread overview]
Message-ID: <tip-1c196a6c771c47a2faa63d38d913e03284f73a16@git.kernel.org> (raw)
In-Reply-To: <1520431349-30689-4-git-send-email-adrian.hunter@intel.com>
Commit-ID: 1c196a6c771c47a2faa63d38d913e03284f73a16
Gitweb: https://git.kernel.org/tip/1c196a6c771c47a2faa63d38d913e03284f73a16
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Wed, 7 Mar 2018 16:02:23 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 8 Mar 2018 10:05:55 -0300
perf intel-pt: Fix error recovery from missing TIP packet
When a TIP packet is expected but there is a different packet, it is an
error. However the unexpected packet might be something important like a
TSC packet, so after the error, it is necessary to continue from there,
rather than the next packet. That is achieved by setting pkt_step to
zero.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1520431349-30689-4-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
index 00f25f4b5f48..5e4d0bbafc8b 100644
--- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
+++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
@@ -1616,6 +1616,7 @@ static int intel_pt_walk_fup_tip(struct intel_pt_decoder *decoder)
case INTEL_PT_PWRX:
intel_pt_log("ERROR: Missing TIP after FUP\n");
decoder->pkt_state = INTEL_PT_STATE_ERR3;
+ decoder->pkt_step = 0;
return -ENOENT;
case INTEL_PT_OVF:
next prev parent reply other threads:[~2018-03-09 8:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 14:02 [PATCH 0/9] perf intel-pt: Some fixes and preparation for AUX area sampling Adrian Hunter
2018-03-07 14:02 ` [PATCH 1/9] perf intel-pt: Fix overlap detection to identify consecutive buffers correctly Adrian Hunter
2018-03-09 8:47 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 2/9] perf intel-pt: Fix sync_switch Adrian Hunter
2018-03-09 8:47 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 3/9] perf intel-pt: Fix error recovery from missing TIP packet Adrian Hunter
2018-03-09 8:48 ` tip-bot for Adrian Hunter [this message]
2018-03-07 14:02 ` [PATCH 4/9] perf intel-pt: Fix timestamp following overflow Adrian Hunter
2018-03-09 8:48 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 5/9] perf intel-pt/bts: In auxtrace_record__init_intel() evlist is never NULL Adrian Hunter
2018-03-09 8:49 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 6/9] perf intel-pt: Get rid of intel_pt_use_buffer_pid_tid() Adrian Hunter
2018-03-09 8:49 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 7/9] perf intel-pt: Tidy old_buffer handling in intel_pt_get_trace() Adrian Hunter
2018-03-09 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 8/9] perf intel-pt: Remove a check for sampling mode Adrian Hunter
2018-03-09 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 9/9] perf intel-pt: Adjust overlap-checking to support " Adrian Hunter
2018-03-09 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:36 ` [PATCH 0/9] perf intel-pt: Some fixes and preparation for AUX area sampling Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1c196a6c771c47a2faa63d38d913e03284f73a16@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).