From: tip-bot for Jan Beulich <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
jbeulich@suse.com, JBeulich@suse.com, tglx@linutronix.de
Subject: [tip:x86/asm] x86: __force_order doesn' t need to be an actual variable
Date: Fri, 31 May 2013 05:48:55 -0700 [thread overview]
Message-ID: <tip-1d10f6ee602ec5a4bd0c1606ba5f38277da432e1@git.kernel.org> (raw)
In-Reply-To: <51A610B802000078000D99A0@nat28.tlf.novell.com>
Commit-ID: 1d10f6ee602ec5a4bd0c1606ba5f38277da432e1
Gitweb: http://git.kernel.org/tip/1d10f6ee602ec5a4bd0c1606ba5f38277da432e1
Author: Jan Beulich <JBeulich@suse.com>
AuthorDate: Wed, 29 May 2013 13:29:12 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 31 May 2013 13:09:17 +0200
x86: __force_order doesn't need to be an actual variable
It being static causes over a dozen instances to be scattered
across the kernel image, with non of them ever being referenced
in any way. Making the variable extern without ever defining it
works as well - all we need is to have the compiler think the
variable is being accessed.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Link: http://lkml.kernel.org/r/51A610B802000078000D99A0@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/special_insns.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h
index 41fc93a..2f4d924 100644
--- a/arch/x86/include/asm/special_insns.h
+++ b/arch/x86/include/asm/special_insns.h
@@ -16,7 +16,7 @@ static inline void native_clts(void)
* all loads stores around it, which can hurt performance. Solution is to
* use a variable and mimic reads and writes to it to enforce serialization
*/
-static unsigned long __force_order;
+extern unsigned long __force_order;
static inline unsigned long native_read_cr0(void)
{
prev parent reply other threads:[~2013-05-31 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 12:29 [PATCH] x86: __force_order doesn't need to be an actual variable Jan Beulich
2013-05-31 12:48 ` tip-bot for Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1d10f6ee602ec5a4bd0c1606ba5f38277da432e1@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox