From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030356AbcGLPkY (ORCPT ); Tue, 12 Jul 2016 11:40:24 -0400 Received: from terminus.zytor.com ([198.137.202.10]:49836 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932331AbcGLPkR (ORCPT ); Tue, 12 Jul 2016 11:40:17 -0400 Date: Tue, 12 Jul 2016 08:40:01 -0700 From: tip-bot for Anna-Maria Gleixner Message-ID: Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, anna-maria@linutronix.de, daniel.lezcano@linaro.org, hpa@zytor.com, tglx@linutronix.de Reply-To: mingo@kernel.org, anna-maria@linutronix.de, daniel.lezcano@linaro.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] clocksource/drivers/time-armada-370-xp: Fix return value check Git-Commit-ID: 1d661bf5327a2c059ec967f850e89362e637f4e6 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1d661bf5327a2c059ec967f850e89362e637f4e6 Gitweb: http://git.kernel.org/tip/1d661bf5327a2c059ec967f850e89362e637f4e6 Author: Anna-Maria Gleixner AuthorDate: Tue, 12 Jul 2016 16:40:09 +0200 Committer: Thomas Gleixner CommitDate: Tue, 12 Jul 2016 17:33:22 +0200 clocksource/drivers/time-armada-370-xp: Fix return value check The failure check of armada_370_xp_timer_setup() in armada_370_xp_timer_common_init() is negated. This leads to an error message and exit in case of a successful initialization. Remove the stray '!'. Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error") Signed-off-by: Anna-Maria Gleixner Cc: Daniel Lezcano Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1607121731020.1344@hypnos.tec.linutronix.de Signed-off-by: Thomas Gleixner --- drivers/clocksource/time-armada-370-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index a4e5923..20ec066 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np) } res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt)); - if (!res) { + if (res) { pr_err("Failed to setup timer"); return res; }