From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbbHaIbL (ORCPT ); Mon, 31 Aug 2015 04:31:11 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37827 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbHaIbJ (ORCPT ); Mon, 31 Aug 2015 04:31:09 -0400 Date: Mon, 31 Aug 2015 01:30:53 -0700 From: tip-bot for Steven Rostedt Message-ID: Cc: acme@redhat.com, linux-kernel@vger.kernel.org, vbabka@suse.cz, namhyung@kernel.org, rostedt@goodmis.org, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org Reply-To: linux-kernel@vger.kernel.org, acme@redhat.com, namhyung@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, vbabka@suse.cz, hpa@zytor.com, mingo@kernel.org In-Reply-To: <20150827094601.46518bcc@gandalf.local.home> References: <20150827094601.46518bcc@gandalf.local.home> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] tools lib traceeveent: Allow for negative numbers in print format Git-Commit-ID: 1d945012d1381f0232ea2d66e32b06182eedb476 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1d945012d1381f0232ea2d66e32b06182eedb476 Gitweb: http://git.kernel.org/tip/1d945012d1381f0232ea2d66e32b06182eedb476 Author: Steven Rostedt AuthorDate: Thu, 27 Aug 2015 09:46:01 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 28 Aug 2015 11:47:40 -0300 tools lib traceeveent: Allow for negative numbers in print format It was reported that "%-8s" does not parse well when used in the printk format. The '-' is what is throwing it off. Allow that to be included. Reporter note: Example before: transhuge-stres-10730 [004] 5897.713989: mm_compaction_finished: node=0 zone=>-<8s order=-2119871790 ret= Example after: transhuge-stres-4235 [000] 453.149280: mm_compaction_finished: node=0 zone=ffffffff81815d7a order=9 ret= (I will send patches to fix the string handling in the tracepoints so it's on par with in-kernel printing via trace_pipe:) transhuge-stres-10921 [007] ...1 6307.140205: mm_compaction_finished: node=0 zone=Normal order=9 ret=partial Reported-by: Vlastimil Babka Signed-off-by: Steven Rostedt Tested-by: Vlastimil Babka Cc: Namhyung Kim Link: http://lkml.kernel.org/r/20150827094601.46518bcc@gandalf.local.home Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/event-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 5c1867a..4d88593 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -4828,6 +4828,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event case 'z': case 'Z': case '0' ... '9': + case '-': goto cont_process; case 'p': if (pevent->long_size == 4)