Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

Ingo Molnar
2018-12-05T18:02:05Z

* Borislav Petkov <bp@alien8.de> wrote:

> On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote:
> > Would it make sense to organize it a bit more and separate out vendor
> > specific functionality:
> >
> > mce/cpu/intel.c
> > mce/cpu/intel-p5.c
> > mce/cpu/amd.c
> > mce/cpu/winchip.c
>
> That's too fine-grained IMO and look at the path we'd get then:
>
> arch/x86/kernel/cpu/mce/cpu/intel.c
> ^^^ ^^^

Oh - I thought we'd have arch/x86/mce/ or so?

There's machine check events that are not tied to any particular CPU,
correct? So this would be the right conceptual level - and it would also
remove the somewhat redundant 'kernel' part.

Thanks,

Ingo