Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

Ingo Molnar
2018-12-05T16:30:45Z

* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
>
> Rename the containing folder to "mce" which is the most widespread name.
> Drop the "mce[-_]" filename prefix of some compilation units (while
> others don't have it).
>
> This unifies the file naming in the MCE subsystem:
>
> mce/
> |-- amd.c
> |-- apei.c
> |-- core.c
> |-- dev-mcelog.c
> |-- genpool.c
> |-- inject.c
> |-- intel.c
> |-- internal.h
> |-- Makefile
> |-- p5.c
> |-- severity.c
> |-- therm_throt.c
> |-- threshold.c
> `-- winchip.c
>
> No functional changes.

Cool!

Would it make sense to organize it a bit more and separate out vendor
specific functionality:

mce/cpu/intel.c
mce/cpu/intel-p5.c
mce/cpu/amd.c
mce/cpu/winchip.c

mce/internal.h
mce/core.c

mce/genpool.c
mce/threshold.c
mce/severity.c
mce/inject.c
mce/therm_throt.c
mce/dev-mcelog.c
mce/apei.c

?

This way there's a clear separation between low level, vendor specific
MCE logic and higher level MCE logic.

mce/apei.c, if this is an Intel-only feature, could perhaps become
mce/cpu/intel-apei.c?

Anyway, your patch is fine too, so whichever subset you decide to use:

Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo