linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Josh Poimboeuf <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jpoimboe@redhat.com, hpa@zytor.com, arnd@arndb.de,
	mingo@kernel.org, peterz@infradead.org,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de
Subject: [tip:x86/asm] objtool: Disable GCC '-Wpacked' warnings
Date: Fri, 28 Jul 2017 00:38:17 -0700	[thread overview]
Message-ID: <tip-21ec3bf6aeb4033210747837421e63286ba32646@git.kernel.org> (raw)
In-Reply-To: <76d85d7b5a87566465095c500bce222ff5d7b146.1501188854.git.jpoimboe@redhat.com>

Commit-ID:  21ec3bf6aeb4033210747837421e63286ba32646
Gitweb:     http://git.kernel.org/tip/21ec3bf6aeb4033210747837421e63286ba32646
Author:     Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Thu, 27 Jul 2017 15:56:56 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 28 Jul 2017 08:33:32 +0200

objtool: Disable GCC '-Wpacked' warnings

Objtool is failing to build with GCC 4.4.7 due to the following
warnings:

  cc1: warnings being treated as errors
  In file included from orc.h:21,
                   from orc_gen.c:21:
  orc_types.h:86: error: packed attribute is unnecessary for ‘sp_offset’
  orc_types.h:87: error: packed attribute is unnecessary for ‘bp_offset’
  orc_types.h:88: error: packed attribute is unnecessary for ‘sp_reg’

I suspect those warnings are a GCC bug.  But -Wpacked isn't very useful
anyway, so just disable it.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 627fce14809b ("objtool: Add ORC unwind table generation")
Link: http://lkml.kernel.org/r/76d85d7b5a87566465095c500bce222ff5d7b146.1501188854.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/objtool/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index 3a6425f..6976c73 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -25,7 +25,8 @@ OBJTOOL_IN := $(OBJTOOL)-in.o
 all: $(OBJTOOL)
 
 INCLUDES := -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi
-CFLAGS   += -Wall -Werror $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -fomit-frame-pointer -O2 -g $(INCLUDES)
+WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
+CFLAGS   += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
 LDFLAGS  += -lelf $(LIBSUBCMD)
 
 # Allow old libelf to be used:

      reply	other threads:[~2017-07-28  7:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 20:56 [PATCH 0/4] objtool: fix some objtool warnings Josh Poimboeuf
2017-07-27 20:56 ` [PATCH 1/4] objtool: Assume unannotated 'ud2' instructions are dead ends Josh Poimboeuf
2017-07-28  7:37   ` [tip:x86/asm] objtool: Assume unannotated UD2 " tip-bot for Josh Poimboeuf
2017-07-27 20:56 ` [PATCH 2/4] objtool: Skip unreachable warnings for 'alt' instructions Josh Poimboeuf
2017-07-28  7:37   ` [tip:x86/asm] " tip-bot for Josh Poimboeuf
2017-07-27 20:56 ` [PATCH 3/4] objtool: Fix '-mtune=atom' decoding support in objtool 2.0 Josh Poimboeuf
2017-07-28  7:37   ` [tip:x86/asm] " tip-bot for Josh Poimboeuf
2017-08-21 14:10   ` [tip:x86/urgent] " tip-bot for Josh Poimboeuf
2017-07-27 20:56 ` [PATCH 4/4] objtool: Disable GCC '-Wpacked' warnings Josh Poimboeuf
2017-07-28  7:38   ` tip-bot for Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-21ec3bf6aeb4033210747837421e63286ba32646@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).