From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216AbeEXFps (ORCPT ); Thu, 24 May 2018 01:45:48 -0400 Received: from terminus.zytor.com ([198.137.202.136]:54861 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755020AbeEXFpl (ORCPT ); Thu, 24 May 2018 01:45:41 -0400 Date: Wed, 23 May 2018 22:45:19 -0700 From: tip-bot for Adrian Hunter Message-ID: Cc: hpa@zytor.com, peterz@infradead.org, tglx@linutronix.de, alexander.shishkin@linux.intel.com, jolsa@redhat.com, joro@8bytes.org, luto@kernel.org, ak@linux.intel.com, acme@redhat.com, mingo@kernel.org, adrian.hunter@intel.com, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org Reply-To: luto@kernel.org, joro@8bytes.org, peterz@infradead.org, hpa@zytor.com, jolsa@redhat.com, alexander.shishkin@linux.intel.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, dave.hansen@linux.intel.com, mingo@kernel.org, acme@redhat.com, ak@linux.intel.com In-Reply-To: <1526986485-6562-18-git-send-email-adrian.hunter@intel.com> References: <1526986485-6562-18-git-send-email-adrian.hunter@intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf kcore_copy: Amend the offset of sections that remap kernel text Git-Commit-ID: 22916fdb9c50e8fb303bdcedca88fd8798a85844 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 22916fdb9c50e8fb303bdcedca88fd8798a85844 Gitweb: https://git.kernel.org/tip/22916fdb9c50e8fb303bdcedca88fd8798a85844 Author: Adrian Hunter AuthorDate: Tue, 22 May 2018 13:54:45 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 23 May 2018 10:26:44 -0300 perf kcore_copy: Amend the offset of sections that remap kernel text x86 PTI entry trampolines all map to the same physical page. If that is reflected in the program headers of /proc/kcore, then do the same for the copy of kcore. Signed-off-by: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Andy Lutomirski Cc: Dave Hansen Cc: H. Peter Anvin Cc: Jiri Olsa Cc: Joerg Roedel Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: x86@kernel.org Link: http://lkml.kernel.org/r/1526986485-6562-18-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/symbol-elf.c | 53 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 584966913aeb..29770ea61768 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -1390,6 +1390,7 @@ struct phdr_data { u64 addr; u64 len; struct list_head node; + struct phdr_data *remaps; }; struct sym_data { @@ -1597,16 +1598,62 @@ static int kcore_copy__read_maps(struct kcore_copy_info *kci, Elf *elf) return 0; } +static void kcore_copy__find_remaps(struct kcore_copy_info *kci) +{ + struct phdr_data *p, *k = NULL; + u64 kend; + + if (!kci->stext) + return; + + /* Find phdr that corresponds to the kernel map (contains stext) */ + kcore_copy__for_each_phdr(kci, p) { + u64 pend = p->addr + p->len - 1; + + if (p->addr <= kci->stext && pend >= kci->stext) { + k = p; + break; + } + } + + if (!k) + return; + + kend = k->offset + k->len; + + /* Find phdrs that remap the kernel */ + kcore_copy__for_each_phdr(kci, p) { + u64 pend = p->offset + p->len; + + if (p == k) + continue; + + if (p->offset >= k->offset && pend <= kend) + p->remaps = k; + } +} + static void kcore_copy__layout(struct kcore_copy_info *kci) { struct phdr_data *p; off_t rel = 0; + kcore_copy__find_remaps(kci); + kcore_copy__for_each_phdr(kci, p) { - p->rel = rel; - rel += p->len; + if (!p->remaps) { + p->rel = rel; + rel += p->len; + } kci->phnum += 1; } + + kcore_copy__for_each_phdr(kci, p) { + struct phdr_data *k = p->remaps; + + if (k) + p->rel = p->offset - k->offset + k->rel; + } } static int kcore_copy__calc_maps(struct kcore_copy_info *kci, const char *dir, @@ -1821,6 +1868,8 @@ int kcore_copy(const char *from_dir, const char *to_dir) kcore_copy__for_each_phdr(&kci, p) { off_t offs = p->rel + offset; + if (p->remaps) + continue; if (copy_bytes(kcore.fd, p->offset, extract.fd, offs, p->len)) goto out_extract_close; }