public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@kernel.org, acme@redhat.com, hpa@zytor.com,
	adrian.hunter@intel.com
Subject: [tip:perf/core] perf scripts python: Fix query in call-graph-from-postgresql.py
Date: Thu, 17 Aug 2017 00:50:39 -0700	[thread overview]
Message-ID: <tip-2295e9f850b0efbc57c81fccdd8bd8d26fe10029@git.kernel.org> (raw)
In-Reply-To: <1501749090-20357-3-git-send-email-adrian.hunter@intel.com>

Commit-ID:  2295e9f850b0efbc57c81fccdd8bd8d26fe10029
Gitweb:     http://git.kernel.org/tip/2295e9f850b0efbc57c81fccdd8bd8d26fe10029
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Thu, 3 Aug 2017 11:31:27 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 15 Aug 2017 16:06:20 -0300

perf scripts python: Fix query in call-graph-from-postgresql.py

Add a missing space which seemed not to affect PostgreSQL but upsets
SQLite.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Link: http://lkml.kernel.org/r/1501749090-20357-3-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/python/call-graph-from-postgresql.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/call-graph-from-postgresql.py b/tools/perf/scripts/python/call-graph-from-postgresql.py
index e78fdc2..ed9f7f3 100644
--- a/tools/perf/scripts/python/call-graph-from-postgresql.py
+++ b/tools/perf/scripts/python/call-graph-from-postgresql.py
@@ -160,7 +160,7 @@ class TreeItem():
 				  '( SELECT short_name FROM dsos WHERE id = ( SELECT dso_id FROM symbols WHERE id = ( SELECT symbol_id FROM call_paths WHERE id = call_path_id ) ) ), '
 				  '( SELECT ip FROM call_paths where id = call_path_id ) '
 				  'FROM calls WHERE parent_call_path_id = ' + str(self.call_path_id) + ' AND comm_id = ' + str(self.comm_id) + ' AND thread_id = ' + str(self.thread_id) +
-				  'ORDER BY call_path_id')
+				  ' ORDER BY call_path_id')
 		if not ret:
 			raise Exception("Query failed: " + query.lastError().text())
 		last_call_path_id = 0

  reply	other threads:[~2017-08-17  7:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  8:31 [PATCH 0/5] perf script: Add support for exporting to sqlite3 Adrian Hunter
2017-08-03  8:31 ` [PATCH 1/5] perf script: Fix missing call_path_id in export-to-postgresql script Adrian Hunter
2017-08-17  7:50   ` [tip:perf/core] perf scripts python: " tip-bot for Adrian Hunter
2017-08-03  8:31 ` [PATCH 2/5] perf script: Fix query in call-graph-from-postgresql.py Adrian Hunter
2017-08-17  7:50   ` tip-bot for Adrian Hunter [this message]
2017-08-03  8:31 ` [PATCH 3/5] perf script: Add support for exporting to sqlite3 Adrian Hunter
2017-08-17  7:51   ` [tip:perf/core] perf script python: " tip-bot for Adrian Hunter
2017-08-03  8:31 ` [PATCH 4/5] perf script: Rename call-graph-from-postgresql.py to call-graph-from-sql.py Adrian Hunter
2017-08-17  7:51   ` [tip:perf/core] perf script python: " tip-bot for Adrian Hunter
2017-08-03  8:31 ` [PATCH 5/5] perf script: Add support for sqlite3 " Adrian Hunter
2017-08-17  7:51   ` [tip:perf/core] perf script python: " tip-bot for Adrian Hunter
2017-08-15  9:25 ` [PATCH 0/5] perf script: Add support for exporting to sqlite3 Adrian Hunter
2017-08-15 19:04   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-2295e9f850b0efbc57c81fccdd8bd8d26fe10029@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox