From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbdGDKwG (ORCPT ); Tue, 4 Jul 2017 06:52:06 -0400 Received: from terminus.zytor.com ([65.50.211.136]:43987 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752239AbdGDKwD (ORCPT ); Tue, 4 Jul 2017 06:52:03 -0400 Date: Tue, 4 Jul 2017 03:49:40 -0700 From: tip-bot for Thomas Gleixner Message-ID: Cc: mingo@kernel.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, heiko@sntech.de, john@metanate.com, daniel.lezcano@linaro.org, hpa@zytor.com, linus.walleij@linaro.org, julia@ni.com, dianders@chromium.org, briannorris@chromium.org Reply-To: mingo@kernel.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, john@metanate.com, heiko@sntech.de, tglx@linutronix.de, hpa@zytor.com, linus.walleij@linaro.org, julia@ni.com, daniel.lezcano@linaro.org, briannorris@chromium.org, dianders@chromium.org In-Reply-To: <20170629214344.196130646@linutronix.de> References: <20170629214344.196130646@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] genirq/timings: Move free timings out of spinlocked region Git-Commit-ID: 2343877fbda701599653e63f8dcc318aa1bf15ee X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 2343877fbda701599653e63f8dcc318aa1bf15ee Gitweb: http://git.kernel.org/tip/2343877fbda701599653e63f8dcc318aa1bf15ee Author: Thomas Gleixner AuthorDate: Thu, 29 Jun 2017 23:33:39 +0200 Committer: Thomas Gleixner CommitDate: Tue, 4 Jul 2017 12:46:16 +0200 genirq/timings: Move free timings out of spinlocked region No point to do memory management from a interrupt disabled spin locked region. Signed-off-by: Thomas Gleixner Reviewed-by: Marc Zyngier Cc: Daniel Lezcano Cc: Heiko Stuebner Cc: Julia Cartwright Cc: Linus Walleij Cc: Brian Norris Cc: Doug Anderson Cc: linux-rockchip@lists.infradead.org Cc: John Keeping Cc: linux-gpio@vger.kernel.org Link: http://lkml.kernel.org/r/20170629214344.196130646@linutronix.de --- kernel/irq/manage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 3e69343..91e1f23 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1489,7 +1489,6 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) if (!desc->action) { irq_settings_clr_disable_unlazy(desc); irq_shutdown(desc); - irq_remove_timings(desc); } #ifdef CONFIG_SMP @@ -1531,8 +1530,10 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) } } - if (!desc->action) + if (!desc->action) { irq_release_resources(desc); + irq_remove_timings(desc); + } mutex_unlock(&desc->request_mutex);