Re: [PATCH] sched: Teach might_sleep() about preemptible RCU

Ingo Molnar
2009-12-17T08:49:33Z

* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> On Wed, Dec 16, 2009 at 08:23:57PM +0100, Frederic Weisbecker wrote:
> > On Wed, Dec 16, 2009 at 08:21:05PM +0100, Frederic Weisbecker wrote:
> > > From: tip-bot for Frederic Weisbecker <fweisbec@gmail.com>
> >
> > Crap... I think I'm really becoming this cyborg...
> >
> > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > Although I've happily put Paul's Reviewed-by tag in this v2,
> > I'd feel more comfortable if he could confirm it :)
>
> Given that I missed the TINY_RCU problem, I am not sure how much my
> Reviewed-by tag is worth, but I have no problem attaching it to this updated
> patch. ;-)

Reviewed-by is valuable in terms of you both acking the patch and expressing
that you thought it through and like it. It does not mean you have done a
mental kernel build test of all 2^3000 kernel .config variants and have proven
the patch correct under circumstances! :-)

So yes, i've added it - thanks Paul!

Ingo