public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Daniel Lezcano <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
	mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com
Subject: [tip:irq/core] genirq/timings: Encapsulate storing function
Date: Wed, 12 Jun 2019 05:30:29 -0700	[thread overview]
Message-ID: <tip-23aa3b9a6b7d5029c1f124426bc5ba4430dcc29c@git.kernel.org> (raw)
In-Reply-To: <20190527205521.12091-6-daniel.lezcano@linaro.org>

Commit-ID:  23aa3b9a6b7d5029c1f124426bc5ba4430dcc29c
Gitweb:     https://git.kernel.org/tip/23aa3b9a6b7d5029c1f124426bc5ba4430dcc29c
Author:     Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate: Mon, 27 May 2019 22:55:18 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 12 Jun 2019 10:47:04 +0200

genirq/timings: Encapsulate storing function

For the next patches providing the selftest, it is required to insert
interval values directly in the buffer in order to check the correctness of
the code. Encapsulate the code doing that in a always inline function in
order to reuse it in the test code.

No functional changes.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: andriy.shevchenko@linux.intel.com
Link: https://lkml.kernel.org/r/20190527205521.12091-6-daniel.lezcano@linaro.org

---
 kernel/irq/timings.c | 53 +++++++++++++++++++++++++++++++++-------------------
 1 file changed, 34 insertions(+), 19 deletions(-)

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 1d1c411d4cae..bc04eca6ef84 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -430,11 +430,43 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
 	return irqs->last_ts + irqs->ema_time[index];
 }
 
+static __always_inline int irq_timings_interval_index(u64 interval)
+{
+	/*
+	 * The PREDICTION_FACTOR increase the interval size for the
+	 * array of exponential average.
+	 */
+	u64 interval_us = (interval >> 10) / PREDICTION_FACTOR;
+
+	return likely(interval_us) ? ilog2(interval_us) : 0;
+}
+
+static __always_inline void __irq_timings_store(int irq, struct irqt_stat *irqs,
+						u64 interval)
+{
+	int index;
+
+	/*
+	 * Get the index in the ema table for this interrupt.
+	 */
+	index = irq_timings_interval_index(interval);
+
+	/*
+	 * Store the index as an element of the pattern in another
+	 * circular array.
+	 */
+	irqs->circ_timings[irqs->count & IRQ_TIMINGS_MASK] = index;
+
+	irqs->ema_time[index] = irq_timings_ema_new(interval,
+						    irqs->ema_time[index]);
+
+	irqs->count++;
+}
+
 static inline void irq_timings_store(int irq, struct irqt_stat *irqs, u64 ts)
 {
 	u64 old_ts = irqs->last_ts;
 	u64 interval;
-	int index;
 
 	/*
 	 * The timestamps are absolute time values, we need to compute
@@ -465,24 +497,7 @@ static inline void irq_timings_store(int irq, struct irqt_stat *irqs, u64 ts)
 		return;
 	}
 
-	/*
-	 * Get the index in the ema table for this interrupt. The
-	 * PREDICTION_FACTOR increase the interval size for the array
-	 * of exponential average.
-	 */
-	index = likely(interval) ?
-		ilog2((interval >> 10) / PREDICTION_FACTOR) : 0;
-
-	/*
-	 * Store the index as an element of the pattern in another
-	 * circular array.
-	 */
-	irqs->circ_timings[irqs->count & IRQ_TIMINGS_MASK] = index;
-
-	irqs->ema_time[index] = irq_timings_ema_new(interval,
-						    irqs->ema_time[index]);
-
-	irqs->count++;
+	__irq_timings_store(irq, irqs, interval);
 }
 
 /**

  reply	other threads:[~2019-06-12 12:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 20:55 [PATCH V3 0/8] genirq/timings: Fixes and selftests Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 1/8] genirq/timings: Fix next event index function Daniel Lezcano
2019-06-12 12:27   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 2/8] genirq/timings: Fix timings buffer inspection Daniel Lezcano
2019-06-12 12:28   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 3/8] genirq/timings: Optimize the period detection speed Daniel Lezcano
2019-06-12 12:29   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 4/8] genirq/timings: Encapsulate timings push Daniel Lezcano
2019-06-12 12:29   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 5/8] genirq/timings: Encapsulate storing function Daniel Lezcano
2019-06-12 12:30   ` tip-bot for Daniel Lezcano [this message]
2019-05-27 20:55 ` [PATCH V3 6/8] genirq/timings: Add selftest for circular array Daniel Lezcano
2019-06-12 12:31   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 7/8] genirq/timings: Add selftest for irqs circular buffer Daniel Lezcano
2019-06-12 12:31   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 8/8] genirq/timings: Add selftest for next event computation Daniel Lezcano
2019-06-12 12:32   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-06-04  6:15 ` [PATCH V3 0/8] genirq/timings: Fixes and selftests Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-23aa3b9a6b7d5029c1f124426bc5ba4430dcc29c@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox