* [PATCH] x86: Use memblock_set_current_limit() to set limit for memblock.
@ 2013-08-14 3:44 Tang Chen
2013-08-14 4:39 ` [tip:x86/mm] " tip-bot for Tang Chen
2013-08-14 6:27 ` [PATCH] " Pekka Enberg
0 siblings, 2 replies; 3+ messages in thread
From: Tang Chen @ 2013-08-14 3:44 UTC (permalink / raw)
To: tglx, mingo, hpa, yinghai, penberg, jacob.shin; +Cc: x86, linux-kernel
In setup_arch() of x86, it set memblock.current_limit directly.
We should use memblock_set_current_limit(). If the implementation
is changed, it is easy to maintain.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
arch/x86/kernel/setup.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f8ec578..de33798 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1070,7 +1070,7 @@ void __init setup_arch(char **cmdline_p)
cleanup_highmap();
- memblock.current_limit = ISA_END_ADDRESS;
+ memblock_set_current_limit(ISA_END_ADDRESS);
memblock_x86_fill();
/*
@@ -1103,7 +1103,7 @@ void __init setup_arch(char **cmdline_p)
setup_real_mode();
- memblock.current_limit = get_max_mapped();
+ memblock_set_current_limit(get_max_mapped());
dma_contiguous_reserve(0);
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/mm] x86: Use memblock_set_current_limit() to set limit for memblock.
2013-08-14 3:44 [PATCH] x86: Use memblock_set_current_limit() to set limit for memblock Tang Chen
@ 2013-08-14 4:39 ` tip-bot for Tang Chen
2013-08-14 6:27 ` [PATCH] " Pekka Enberg
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Tang Chen @ 2013-08-14 4:39 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, tangchen, tglx, hpa
Commit-ID: 2449f343e4adc778de1c3d45b5aa14fe788663f5
Gitweb: http://git.kernel.org/tip/2449f343e4adc778de1c3d45b5aa14fe788663f5
Author: Tang Chen <tangchen@cn.fujitsu.com>
AuthorDate: Wed, 14 Aug 2013 11:44:04 +0800
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Tue, 13 Aug 2013 21:27:02 -0700
x86: Use memblock_set_current_limit() to set limit for memblock.
In setup_arch() of x86, it set memblock.current_limit directly.
We should use memblock_set_current_limit(). If the implementation
is changed, it is easy to maintain.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Link: http://lkml.kernel.org/r/1376451844-15682-1-git-send-email-tangchen@cn.fujitsu.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/kernel/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f8ec578..de33798 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1070,7 +1070,7 @@ void __init setup_arch(char **cmdline_p)
cleanup_highmap();
- memblock.current_limit = ISA_END_ADDRESS;
+ memblock_set_current_limit(ISA_END_ADDRESS);
memblock_x86_fill();
/*
@@ -1103,7 +1103,7 @@ void __init setup_arch(char **cmdline_p)
setup_real_mode();
- memblock.current_limit = get_max_mapped();
+ memblock_set_current_limit(get_max_mapped());
dma_contiguous_reserve(0);
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Use memblock_set_current_limit() to set limit for memblock.
2013-08-14 3:44 [PATCH] x86: Use memblock_set_current_limit() to set limit for memblock Tang Chen
2013-08-14 4:39 ` [tip:x86/mm] " tip-bot for Tang Chen
@ 2013-08-14 6:27 ` Pekka Enberg
1 sibling, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2013-08-14 6:27 UTC (permalink / raw)
To: Tang Chen; +Cc: tglx, mingo, hpa, yinghai, jacob.shin, x86, linux-kernel
On 8/14/13 6:44 AM, Tang Chen wrote:
> In setup_arch() of x86, it set memblock.current_limit directly.
> We should use memblock_set_current_limit(). If the implementation
> is changed, it is easy to maintain.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-14 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-14 3:44 [PATCH] x86: Use memblock_set_current_limit() to set limit for memblock Tang Chen
2013-08-14 4:39 ` [tip:x86/mm] " tip-bot for Tang Chen
2013-08-14 6:27 ` [PATCH] " Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).