[PATCH] perf, tools, stat: Quieten failed to read counter message

[PATCH] perf, tools, stat: Quieten failed to read counter message

[Andi Kleen]

From: Andi Kleen <ak@linux.intel.com>

Since 3b3eb0445 running perf stat on a system without
backend-stalled-cycles spits out ugly warnings by default. Since that is quite
common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported>
output.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d46dbb1..a96fb5c 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
 
 	evlist__for_each(evsel_list, counter) {
 		if (read_counter(counter))
-			pr_warning("failed to read counter %s\n", counter->name);
+			pr_debug("failed to read counter %s\n", counter->name);
 
 		if (perf_stat_process_counter(&stat_config, counter))
 			pr_warning("failed to process counter %s\n", counter->name);
-- 
2.4.3

Re: [PATCH] perf, tools, stat: Quieten failed to read counter message

[Jiri Olsa]

On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Since 3b3eb0445 running perf stat on a system without
> backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> common, make the message a debug message only. We know
> anyways that the counter wasn't read by the normal <unsupported>
> output.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/builtin-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d46dbb1..a96fb5c 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
>  
>  	evlist__for_each(evsel_list, counter) {
>  		if (read_counter(counter))
> -			pr_warning("failed to read counter %s\n", counter->name);
> +			pr_debug("failed to read counter %s\n", counter->name);
>  
>  		if (perf_stat_process_counter(&stat_config, counter))
>  			pr_warning("failed to process counter %s\n", counter->name);
> -- 
> 2.4.3
> 

Re: [PATCH] perf, tools, stat: Quieten failed to read counter message

[Arnaldo Carvalho de Melo]

Em Wed, Sep 02, 2015 at 08:07:20AM +0200, Jiri Olsa escreveu:
> On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > Since 3b3eb0445 running perf stat on a system without
> > backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> > common, make the message a debug message only. We know
> > anyways that the counter wasn't read by the normal <unsupported>
> > output.
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo

[tip:perf/core] perf stat: Quieten failed to read counter message

[tip-bot for Andi Kleen]

Commit-ID:  245bad8eb45fca36638da53fb0a361397a707001
Gitweb:     http://git.kernel.org/tip/245bad8eb45fca36638da53fb0a361397a707001
Author:     Andi Kleen <ak@linux.intel.com>
AuthorDate: Tue, 1 Sep 2015 15:52:46 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 2 Sep 2015 16:30:47 -0300

perf stat: Quieten failed to read counter message

Since 3b3eb0445 running perf stat on a system without
backend-stalled-cycles spits out ugly warnings by default.

Since that is quite common, make the message a debug message only.

We know anyways that the counter wasn't read by the normal <unsupported>
output.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1441147966-14917-1-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d46dbb1..a96fb5c 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
 
 	evlist__for_each(evsel_list, counter) {
 		if (read_counter(counter))
-			pr_warning("failed to read counter %s\n", counter->name);
+			pr_debug("failed to read counter %s\n", counter->name);
 
 		if (perf_stat_process_counter(&stat_config, counter))
 			pr_warning("failed to process counter %s\n", counter->name);