public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 0/2] blackfin: Interrupt cleanups and API change preparation
@ 2015-07-13 20:34 Thomas Gleixner
  2015-07-13 20:34 ` [patch 1/2] blackfin/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
  2015-07-13 20:34 ` [patch 2/2] blackfin/irq: Use irq_set_handler_locked() Thomas Gleixner
  0 siblings, 2 replies; 5+ messages in thread
From: Thomas Gleixner @ 2015-07-13 20:34 UTC (permalink / raw)
  To: LKML; +Cc: Steven Miao, Jiang Liu

The following patch series contains the following changes:

    - Consolidation of chained interrupt handler setup/removal

    - Switch to functions which avoid a redundant interrupt
      descriptor lookup

    - Preparation of interrupt flow handlers for the 'irq' argument
      removal

The series has no dependencies and is also available as a git branch
for your convenience:

 git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/blackfin

If you want me to carry the patches in the irq/core branch of tip,
please let me know.

Thanks,

	tglx


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [patch 1/2] blackfin/irq: Use access helper irq_data_get_affinity_mask()
  2015-07-13 20:34 [patch 0/2] blackfin: Interrupt cleanups and API change preparation Thomas Gleixner
@ 2015-07-13 20:34 ` Thomas Gleixner
  2015-07-27 15:54   ` [tip:irq/core] " tip-bot for Jiang Liu
  2015-07-13 20:34 ` [patch 2/2] blackfin/irq: Use irq_set_handler_locked() Thomas Gleixner
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2015-07-13 20:34 UTC (permalink / raw)
  To: LKML; +Cc: Steven Miao, Jiang Liu, adi-buildroot-devel

[-- Attachment #1: blackfin-irq-Use-access-helper-irq_data_get_affinity.patch --]
[-- Type: text/plain, Size: 984 bytes --]

From: Jiang Liu <jiang.liu@linux.intel.com>

This is a preparatory patch for moving irq_data struct members.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: adi-buildroot-devel@lists.sourceforge.net
Cc: Steven Miao <realmz6@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/blackfin/mach-common/ints-priority.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: tip/arch/blackfin/mach-common/ints-priority.c
===================================================================
--- tip.orig/arch/blackfin/mach-common/ints-priority.c
+++ tip/arch/blackfin/mach-common/ints-priority.c
@@ -194,7 +194,8 @@ void bfin_internal_unmask_irq(unsigned i
 #ifdef CONFIG_SMP
 static void bfin_internal_unmask_irq_chip(struct irq_data *d)
 {
-	bfin_internal_unmask_irq_affinity(d->irq, d->affinity);
+	bfin_internal_unmask_irq_affinity(d->irq,
+					  irq_data_get_affinity_mask(d));
 }
 
 static int bfin_internal_set_affinity(struct irq_data *d,



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [patch 2/2] blackfin/irq: Use irq_set_handler_locked()
  2015-07-13 20:34 [patch 0/2] blackfin: Interrupt cleanups and API change preparation Thomas Gleixner
  2015-07-13 20:34 ` [patch 1/2] blackfin/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
@ 2015-07-13 20:34 ` Thomas Gleixner
  2015-07-27 15:55   ` [tip:irq/core] " tip-bot for Thomas Gleixner
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2015-07-13 20:34 UTC (permalink / raw)
  To: LKML; +Cc: Steven Miao, Jiang Liu, Julia Lawall, adi-buildroot-devel

[-- Attachment #1: blackfin-irq-Use-irq_set_handler_locked.patch --]
[-- Type: text/plain, Size: 1438 bytes --]

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and update was done with coccinelle.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Steven Miao <realmz6@gmail.com>
Cc: adi-buildroot-devel@lists.sourceforge.net
---
 arch/blackfin/mach-common/ints-priority.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: tip/arch/blackfin/mach-common/ints-priority.c
===================================================================
--- tip.orig/arch/blackfin/mach-common/ints-priority.c
+++ tip/arch/blackfin/mach-common/ints-priority.c
@@ -686,12 +686,12 @@ void bfin_demux_mac_status_irq(unsigned
 }
 #endif
 
-static inline void bfin_set_irq_handler(unsigned irq, irq_flow_handler_t handle)
+static inline void bfin_set_irq_handler(struct irq_data *d, irq_flow_handler_t handle)
 {
 #ifdef CONFIG_IPIPE
 	handle = handle_level_irq;
 #endif
-	__irq_set_handler_locked(irq, handle);
+	irq_set_handler_locked(d, handle);
 }
 
 #ifdef CONFIG_GPIO_ADI
@@ -803,9 +803,9 @@ static int bfin_gpio_irq_type(struct irq
 	}
 
 	if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
-		bfin_set_irq_handler(irq, handle_edge_irq);
+		bfin_set_irq_handler(d, handle_edge_irq);
 	else
-		bfin_set_irq_handler(irq, handle_level_irq);
+		bfin_set_irq_handler(d, handle_level_irq);
 
 	return 0;
 }



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip:irq/core] blackfin/irq: Use access helper irq_data_get_affinity_mask()
  2015-07-13 20:34 ` [patch 1/2] blackfin/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
@ 2015-07-27 15:54   ` tip-bot for Jiang Liu
  0 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Jiang Liu @ 2015-07-27 15:54 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: jiang.liu, realmz6, hpa, linux-kernel, tglx, mingo

Commit-ID:  247bd4f1f11eb683bdb31850b525fb5e893bd49d
Gitweb:     http://git.kernel.org/tip/247bd4f1f11eb683bdb31850b525fb5e893bd49d
Author:     Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Mon, 13 Jul 2015 20:34:56 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 27 Jul 2015 13:36:37 +0200

blackfin/irq: Use access helper irq_data_get_affinity_mask()

This is a preparatory patch for moving irq_data struct members.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Steven Miao <realmz6@gmail.com>
Cc: adi-buildroot-devel@lists.sourceforge.net
Link: http://lkml.kernel.org/r/20150713125611.652550580@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/blackfin/mach-common/ints-priority.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/blackfin/mach-common/ints-priority.c b/arch/blackfin/mach-common/ints-priority.c
index 7236bdf..332a434 100644
--- a/arch/blackfin/mach-common/ints-priority.c
+++ b/arch/blackfin/mach-common/ints-priority.c
@@ -194,7 +194,8 @@ void bfin_internal_unmask_irq(unsigned int irq)
 #ifdef CONFIG_SMP
 static void bfin_internal_unmask_irq_chip(struct irq_data *d)
 {
-	bfin_internal_unmask_irq_affinity(d->irq, d->affinity);
+	bfin_internal_unmask_irq_affinity(d->irq,
+					  irq_data_get_affinity_mask(d));
 }
 
 static int bfin_internal_set_affinity(struct irq_data *d,

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [tip:irq/core] blackfin/irq: Use irq_set_handler_locked()
  2015-07-13 20:34 ` [patch 2/2] blackfin/irq: Use irq_set_handler_locked() Thomas Gleixner
@ 2015-07-27 15:55   ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Thomas Gleixner @ 2015-07-27 15:55 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: tglx, mingo, julia.lawall, hpa, jiang.liu, realmz6, linux-kernel

Commit-ID:  284384442fd44f6e01a157745b5549602e6a49f4
Gitweb:     http://git.kernel.org/tip/284384442fd44f6e01a157745b5549602e6a49f4
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Mon, 13 Jul 2015 20:34:57 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 27 Jul 2015 13:36:37 +0200

blackfin/irq: Use irq_set_handler_locked()

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and update was done with coccinelle.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Miao <realmz6@gmail.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: adi-buildroot-devel@lists.sourceforge.net
Link: http://lkml.kernel.org/r/20150713125611.731615902@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/blackfin/mach-common/ints-priority.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/blackfin/mach-common/ints-priority.c b/arch/blackfin/mach-common/ints-priority.c
index 332a434..2eaf83a 100644
--- a/arch/blackfin/mach-common/ints-priority.c
+++ b/arch/blackfin/mach-common/ints-priority.c
@@ -686,12 +686,12 @@ void bfin_demux_mac_status_irq(unsigned int int_err_irq,
 }
 #endif
 
-static inline void bfin_set_irq_handler(unsigned irq, irq_flow_handler_t handle)
+static inline void bfin_set_irq_handler(struct irq_data *d, irq_flow_handler_t handle)
 {
 #ifdef CONFIG_IPIPE
 	handle = handle_level_irq;
 #endif
-	__irq_set_handler_locked(irq, handle);
+	irq_set_handler_locked(d, handle);
 }
 
 #ifdef CONFIG_GPIO_ADI
@@ -803,9 +803,9 @@ static int bfin_gpio_irq_type(struct irq_data *d, unsigned int type)
 	}
 
 	if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
-		bfin_set_irq_handler(irq, handle_edge_irq);
+		bfin_set_irq_handler(d, handle_edge_irq);
 	else
-		bfin_set_irq_handler(irq, handle_level_irq);
+		bfin_set_irq_handler(d, handle_level_irq);
 
 	return 0;
 }

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-07-27 15:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 20:34 [patch 0/2] blackfin: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:34 ` [patch 1/2] blackfin/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
2015-07-27 15:54   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-13 20:34 ` [patch 2/2] blackfin/irq: Use irq_set_handler_locked() Thomas Gleixner
2015-07-27 15:55   ` [tip:irq/core] " tip-bot for Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox