[PATCH] tools lib traceevent: Clean up format of args in cfg80211 plugin

[PATCH] tools lib traceevent: Clean up format of args in cfg80211 plugin

[Steven Rostedt]

While synchronizing what's in trace-cmd vs what's in perf, I came
across a change that was made when entering the cfg80211 plugin into
the tools/lib/traceevent directory. The function prototype went from:

static unsigned long long process___le16_to_cpup(struct trace_seq *s,
						 unsigned long long *args)

to:

static unsigned long long
process___le16_to_cpup(struct trace_seq *s,
		       unsigned long long *args)

I can understand the line break after the long long, but there's no
reason to keep args on a separate line.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c
index c066b25..4592d84 100644
--- a/tools/lib/traceevent/plugin_cfg80211.c
+++ b/tools/lib/traceevent/plugin_cfg80211.c
@@ -5,8 +5,7 @@
 #include "event-parse.h"
 
 static unsigned long long
-process___le16_to_cpup(struct trace_seq *s,
-		       unsigned long long *args)
+process___le16_to_cpup(struct trace_seq *s, unsigned long long *args)
 {
 	uint16_t *val = (uint16_t *) (unsigned long) args[0];
 	return val ? (long long) le16toh(*val) : 0;

Re: [PATCH] tools lib traceevent: Clean up format of args in cfg80211 plugin

[Jiri Olsa]

On Thu, Jun 12, 2014 at 07:44:20PM -0400, Steven Rostedt wrote:
> While synchronizing what's in trace-cmd vs what's in perf, I came
> across a change that was made when entering the cfg80211 plugin into
> the tools/lib/traceevent directory. The function prototype went from:
> 
> static unsigned long long process___le16_to_cpup(struct trace_seq *s,
> 						 unsigned long long *args)
> 
> to:
> 
> static unsigned long long
> process___le16_to_cpup(struct trace_seq *s,
> 		       unsigned long long *args)
> 
> I can understand the line break after the long long, but there's no
> reason to keep args on a separate line.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

queued, thanks

jirka

> ---
> diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c
> index c066b25..4592d84 100644
> --- a/tools/lib/traceevent/plugin_cfg80211.c
> +++ b/tools/lib/traceevent/plugin_cfg80211.c
> @@ -5,8 +5,7 @@
>  #include "event-parse.h"
>  
>  static unsigned long long
> -process___le16_to_cpup(struct trace_seq *s,
> -		       unsigned long long *args)
> +process___le16_to_cpup(struct trace_seq *s, unsigned long long *args)
>  {
>  	uint16_t *val = (uint16_t *) (unsigned long) args[0];
>  	return val ? (long long) le16toh(*val) : 0;

[tip:perf/core] tools lib traceevent: Clean up format of args in cfg80211 plugin

[tip-bot for Steven Rostedt]

Commit-ID:  24eda087ccbb32f556cb3f9f78be152312bf6cc4
Gitweb:     http://git.kernel.org/tip/24eda087ccbb32f556cb3f9f78be152312bf6cc4
Author:     Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Thu, 12 Jun 2014 19:44:20 -0400
Committer:  Jiri Olsa <jolsa@kernel.org>
CommitDate: Thu, 19 Jun 2014 18:18:36 +0200

tools lib traceevent: Clean up format of args in cfg80211 plugin

While synchronizing what's in trace-cmd vs what's in perf, I came
across a change that was made when entering the cfg80211 plugin into
the tools/lib/traceevent directory. The function prototype went from:

static unsigned long long process___le16_to_cpup(struct trace_seq *s,
						 unsigned long long *args)

to:

static unsigned long long
process___le16_to_cpup(struct trace_seq *s,
		       unsigned long long *args)

I can understand the line break after the long long, but there's no
reason to keep args on a separate line.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140612194420.24073744@gandalf.local.home
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/lib/traceevent/plugin_cfg80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c
index c066b25..4592d84 100644
--- a/tools/lib/traceevent/plugin_cfg80211.c
+++ b/tools/lib/traceevent/plugin_cfg80211.c
@@ -5,8 +5,7 @@
 #include "event-parse.h"
 
 static unsigned long long
-process___le16_to_cpup(struct trace_seq *s,
-		       unsigned long long *args)
+process___le16_to_cpup(struct trace_seq *s, unsigned long long *args)
 {
 	uint16_t *val = (uint16_t *) (unsigned long) args[0];
 	return val ? (long long) le16toh(*val) : 0;