Re: [PATCH 21/21] time: Rework debugging variables so they aren't global

Peter Zijlstra
2015-04-02T08:37:09Z

On Thu, Apr 02, 2015 at 09:51:51AM +0200, Ingo Molnar wrote:
>
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Wed, Apr 01, 2015 at 08:34:41PM -0700, John Stultz wrote:
> > > Ingo suggested that the timekeeping debugging variables
> > > recently added should not be global, and should be tied
> > > to the timekeeper's read_base.
> >
> > But why? its the same hardware clock for both tkr's. Surely if one goes
> > funny the other will too.
> >
> > It doesn't make sense to duplicate this.
>
> Well, could it be moved to the timekeeper data structure? What I was
> opposed to was making it super-global, after all the (nice) effort we
> made to tidy up global data structures in this area.

Sure, struct timekeeper would work, the debug code already references
the global tk_core to access that.