From: tip-bot for Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Brice.Goglin@inria.fr,
hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perfcounters/urgent] perf tools: Fix multi-counter stat bug caused by incorrect reading of perf.data file header
Date: Fri, 7 Aug 2009 06:37:07 GMT [thread overview]
Message-ID: <tip-28d4db10a0f2a2a6cb9a843522f433ff0185c784@git.kernel.org> (raw)
In-Reply-To: <1249585061.4975.17.camel@laptop>
Commit-ID: 28d4db10a0f2a2a6cb9a843522f433ff0185c784
Gitweb: http://git.kernel.org/tip/28d4db10a0f2a2a6cb9a843522f433ff0185c784
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Thu, 6 Aug 2009 20:57:41 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 7 Aug 2009 08:32:55 +0200
perf tools: Fix multi-counter stat bug caused by incorrect reading of perf.data file header
Brice Goglin reported that only the first result from a
multi-counter perf record --stat run is accurate, the
rest looks bogus.
A silly mistake made us re-read the first attribute for
every recorded attribute.
Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Brice Goglin <Brice.Goglin@inria.fr>
Cc: paulus@samba.org
LKML-Reference: <1249585061.4975.17.camel@laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
| 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 450384b..95a44bc 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -213,9 +213,10 @@ struct perf_header *perf_header__read(int fd)
for (i = 0; i < nr_attrs; i++) {
struct perf_header_attr *attr;
- off_t tmp = lseek(fd, 0, SEEK_CUR);
+ off_t tmp;
do_read(fd, &f_attr, sizeof(f_attr));
+ tmp = lseek(fd, 0, SEEK_CUR);
attr = perf_header_attr__new(&f_attr.attr);
next prev parent reply other threads:[~2009-08-07 6:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 20:54 [perf] howto switch from pfmon Brice Goglin
2009-06-23 12:12 ` Andi Kleen
2009-06-23 12:23 ` Peter Zijlstra
2009-06-23 13:57 ` Ingo Molnar
2009-06-23 13:14 ` Ingo Molnar
2009-06-23 13:22 ` Peter Zijlstra
2009-06-23 13:38 ` Ingo Molnar
2009-06-23 13:25 ` Ingo Molnar
2009-06-23 13:47 ` Ingo Molnar
2009-06-23 14:00 ` Brice Goglin
2009-06-23 14:36 ` Ingo Molnar
2009-06-23 15:22 ` Brice Goglin
2009-06-29 19:29 ` Ingo Molnar
2009-08-06 16:59 ` Brice Goglin
2009-08-06 17:40 ` Peter Zijlstra
2009-08-06 17:48 ` Brice Goglin
2009-08-06 17:59 ` Peter Zijlstra
2009-08-06 18:57 ` [PATCH] perf tools: Fix reading of perf.data file header Peter Zijlstra
2009-08-06 19:03 ` Brice Goglin
2009-08-06 19:59 ` Ingo Molnar
2009-08-06 20:03 ` Brice Goglin
2009-08-06 23:35 ` Brice Goglin
2009-08-07 6:13 ` Brice Goglin
2009-08-07 6:32 ` Ingo Molnar
2009-08-07 7:38 ` Brice Goglin
2009-08-07 7:45 ` Ingo Molnar
2009-08-07 8:18 ` Brice Goglin
2009-08-07 8:23 ` Ingo Molnar
2009-08-07 8:27 ` Ingo Molnar
2009-08-07 8:30 ` [tip:perfcounters/core] perf stat: Rename -S/--scale to -c/--scale tip-bot for Brice Goglin
2009-08-07 11:55 ` [PATCH] perf report: Display per-thread event counters Brice Goglin
2009-08-08 11:54 ` [tip:perfcounters/core] perf report: Fix and improve the displaying of " tip-bot for Brice Goglin
2009-08-08 12:14 ` [PATCH] perf report: Display " Ingo Molnar
2009-08-08 16:10 ` Brice Goglin
2009-08-08 16:13 ` Ingo Molnar
2009-08-07 6:37 ` tip-bot for Peter Zijlstra [this message]
2009-08-07 7:39 ` [tip:perfcounters/urgent] perf tools: Fix multi-counter stat bug caused by incorrect reading of perf.data file header tip-bot for Peter Zijlstra
2009-08-06 19:01 ` [perf] howto switch from pfmon Brice Goglin
2009-06-23 14:21 ` Brice Goglin
2009-06-23 14:51 ` Ingo Molnar
2009-06-23 15:29 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-28d4db10a0f2a2a6cb9a843522f433ff0185c784@git.kernel.org \
--to=a.p.zijlstra@chello.nl \
--cc=Brice.Goglin@inria.fr \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox