Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps

Arnaldo Carvalho de Melo
2015-09-15T14:18:05Z

Em Tue, Sep 15, 2015 at 09:52:56AM +0300, Adrian Hunter escreveu:
> On 08/09/15 11:08, Jiri Olsa wrote:
> > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
> >> Hi
> >>
> >> Here is V3 of "Fix gaps propagating maps" that fixes some problems
> >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
> >>
> >> Changes in V3:
> >>
> >> perf tools: Remove redundant validation from perf_evlist__propagate_maps
> >> perf_evlist__set_maps also doesn't need to return an error anymore
> >>
> >> perf tools: Add evlist->has_user_cpus
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix task exit test setting maps
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix software clock events test setting maps
> >> Adjusted due to perf_evlist__set_maps change
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Hi Arnaldo
>
> Please don't forget these. Intel PT is broken on 4.3 without them i.e.
>
> $ tools/perf/perf --version
> perf version 4.3.rc1.gd25ed
> $ tools/perf/perf record -e intel_pt//u uname
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
> event (sched:sched_switch).

Ok, applied the series, with just one change, which was patch-cosmetic,
see the other message I'll send.

- Arnaldo