Re: [patch V4 01/32] mm/slab: Fix broken stack trace storage

Peter Zijlstra
2019-04-15T16:21:57Z

On Mon, Apr 15, 2019 at 06:07:44PM +0200, Thomas Gleixner wrote:
> On Mon, 15 Apr 2019, Josh Poimboeuf wrote:
> > > + struct stack_trace trace = {
> > > + /* Leave one for the end marker below */
> > > + .max_entries = size - 1,
> > > + .entries = addr,
> > > + .skip = 3,
> > > + };

> > Looks like stack_trace.nr_entries isn't initialized? (though this code
> > gets eventually replaced by a later patch)
>
> struct initializer initialized the non mentioned fields to 0, if I'm not
> totally mistaken.

Correct.