From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jaswinder@kernel.org, jaswinderrajput@gmail.com,
suresh.b.siddha@intel.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/cleanups] x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static
Date: Sun, 12 Apr 2009 11:21:32 GMT [thread overview]
Message-ID: <tip-2de1f33e99cec5fd79542a1d0e26efb9c36a98bb@git.kernel.org> (raw)
In-Reply-To: <1239434726.4418.24.camel@localhost.localdomain>
Commit-ID: 2de1f33e99cec5fd79542a1d0e26efb9c36a98bb
Gitweb: http://git.kernel.org/tip/2de1f33e99cec5fd79542a1d0e26efb9c36a98bb
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Sat, 11 Apr 2009 12:55:26 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 12 Apr 2009 12:39:24 +0200
x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <1239434726.4418.24.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/x2apic_cluster.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 4a903e2..8e4cbb2 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -10,7 +10,7 @@
#include <asm/apic.h>
#include <asm/ipi.h>
-DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
+static DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
{
prev parent reply other threads:[~2009-04-12 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 7:25 [PATCH -tip] x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static Jaswinder Singh Rajput
2009-04-12 10:39 ` [tip:x86/cleanups] " Jaswinder Singh Rajput
2009-04-12 10:51 ` [PATCH -tip] " Ingo Molnar
2009-04-12 11:47 ` Jaswinder Singh Rajput
2009-04-12 11:21 ` Jaswinder Singh Rajput [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2de1f33e99cec5fd79542a1d0e26efb9c36a98bb@git.kernel.org \
--to=jaswinder@kernel.org \
--cc=hpa@zytor.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox