From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, eranian@google.com,
paulus@samba.org, hpa@zytor.com, mingo@kernel.org,
jolsa@kernel.org, a.p.zijlstra@chello.nl, acme@kernel.org,
namhyung@kernel.org, fweisbec@gmail.com, dsahern@gmail.com,
tglx@linutronix.de, cjashfor@linux.vnet.ibm.com
Subject: [tip:perf/core] perf tools: Remove elide setup for SORT_MODE__MEMORY mode
Date: Thu, 5 Jun 2014 07:31:52 -0700 [thread overview]
Message-ID: <tip-2ec85c628c4cecef0f82d177279c579aed0f9706@git.kernel.org> (raw)
In-Reply-To: <1400858147-7155-2-git-send-email-jolsa@kernel.org>
Commit-ID: 2ec85c628c4cecef0f82d177279c579aed0f9706
Gitweb: http://git.kernel.org/tip/2ec85c628c4cecef0f82d177279c579aed0f9706
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 23 May 2014 17:15:46 +0200
Committer: Jiri Olsa <jolsa@kernel.org>
CommitDate: Tue, 3 Jun 2014 21:34:53 +0200
perf tools: Remove elide setup for SORT_MODE__MEMORY mode
There's no need to setup elide of sort_dso sort entry again
with symbol_conf.dso_list list.
The only difference were list names of memory mode data,
which does not make much sense to me.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1400858147-7155-2-git-send-email-jolsa@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/util/sort.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 254f583..2aba620 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1412,19 +1412,6 @@ void sort__setup_elide(FILE *output)
sort_entry__setup_elide(&sort_sym_to,
symbol_conf.sym_to_list,
"sym_to", output);
- } else if (sort__mode == SORT_MODE__MEMORY) {
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "symbol_daddr", output);
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "dso_daddr", output);
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "mem", output);
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "local_weight", output);
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "tlb", output);
- sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
- "snoop", output);
}
/*
next prev parent reply other threads:[~2014-06-05 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 15:15 [RFC/PATCH 0/2] perf tools: Factor sort elide Jiri Olsa
2014-05-23 15:15 ` [PATCH 1/2] perf tools: Remove elide setup for SORT_MODE__MEMORY mode Jiri Olsa
2014-06-05 14:31 ` tip-bot for Jiri Olsa [this message]
2014-05-23 15:15 ` [PATCH 2/2] perf tools: Move elide bool into perf_hpp_fmt struct Jiri Olsa
2014-05-30 5:47 ` [RFC/PATCH 0/2] perf tools: Factor sort elide Namhyung Kim
2014-06-01 14:26 ` [PATCHv2] perf tools: Move elide bool into perf_hpp_fmt struct Jiri Olsa
2014-06-02 11:56 ` [RFC/BUG] not working LLC-load-misses on SandyBridge (42) and Haswell Jiri Olsa
2014-06-02 15:25 ` Andi Kleen
2014-06-05 14:32 ` [tip:perf/core] perf tools: Move elide bool into perf_hpp_fmt struct tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2ec85c628c4cecef0f82d177279c579aed0f9706@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox