Re: [PATCH] sched_groups are expected to be circular linked list, make it so right after allocation

Peter Zijlstra
2012-05-10T17:33:57Z

On Thu, 2012-05-10 at 13:01 -0400, Igor Mammedov wrote:
> However cpu that has been blissfully forgotten, continues to boot and sets
> cpu_active_mask. So causing all sorts of havoc in places that use this mask.
> Then when next cpu is being onlined/offlined it eventually calls
> CPU_[ONLINE|DOWN]->cpuset_update_active_cpus()
> result is OOPS.
>
> That is why I've posted https://lkml.org/lkml/2012/5/9/125
> that prevent all of this from happening by 'gracefully' aborting boot
> process on failed cpu with necessary cleanup.
>
> Checked Ingo's git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git:master
> races, that patches 1, 2, 4 are fixing, are still there.
> If it is preferable for this patches to go into -tip, then I'll rebase them
> on top of it and repost. ???

Right, I'd hoped tglx would respond as he's got more stuff on his
harddrive. But he's been rather quiet the past few days. This either
means he's ignoring us all and working very hard to finish these patches
so he can post them and delight us all with a new hotplug
infrastructure. Or not and there's something else..

Anyway, I think you're right in that fixing that bringup fail is
important -- and you've done the work already, so yeah unless tglx shows
up soon your patches ought to go on.

I'll try and have a peek at them soon.