From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, acme@redhat.com, hpa@zytor.com,
a.p.zijlstra@chello.nl, jolsa@kernel.org, tglx@linutronix.de,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
andi@firstfloor.org
Subject: [tip:perf/core] perf report: Enable group view with hierarchy
Date: Tue, 20 Sep 2016 14:41:37 -0700 [thread overview]
Message-ID: <tip-30d476ae738d1ce33f170dd79398ecd211274df6@git.kernel.org> (raw)
In-Reply-To: <20160913074552.13284-8-namhyung@kernel.org>
Commit-ID: 30d476ae738d1ce33f170dd79398ecd211274df6
Gitweb: http://git.kernel.org/tip/30d476ae738d1ce33f170dd79398ecd211274df6
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 13 Sep 2016 16:45:52 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 13 Sep 2016 16:43:41 -0300
perf report: Enable group view with hierarchy
Now that all the missing pieces are implemented, let's enable it. An
example output below:
$ perf record -e '{cycles,instructions}' make
$ perf report --hierarchy --stdio
...
# Overhead Command / Shared Object / Symbol
# ...................... ..................................
#
...
25.74% 27.18% sh
19.96% 24.14% libc-2.24.so
9.55% 14.64% [.] __strcmp_sse2
1.54% 0.00% [.] __tfind
1.07% 1.13% [.] _int_malloc
0.95% 0.00% [.] __strchr_sse2
0.89% 1.39% [.] __tsearch
0.76% 0.00% [.] strlen
...
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Requested-by: Andi Kleen <andi@firstfloor.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20160913074552.13284-8-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 1a07c4c..6e88460 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -935,7 +935,6 @@ repeat:
if (symbol_conf.report_hierarchy) {
/* disable incompatible options */
- symbol_conf.event_group = false;
symbol_conf.cumulate_callchain = false;
if (field_order) {
prev parent reply other threads:[~2016-09-20 21:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:45 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v2) Namhyung Kim
2016-09-13 7:45 ` [PATCH 1/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim
2016-09-19 7:48 ` Jiri Olsa
2016-09-20 1:10 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim
2016-09-19 7:59 ` Jiri Olsa
2016-09-20 1:17 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 3/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim
2016-09-20 21:40 ` [tip:perf/core] perf hist: Initialize hierarchy " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 4/7] perf ui/stdio: Always reset output width for hierarchy Namhyung Kim
2016-09-20 21:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 5/7] perf ui/stdio: Rename print_hierarchy_header() Namhyung Kim
2016-09-20 21:41 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim
2016-09-19 8:05 ` Jiri Olsa
2016-09-20 1:18 ` Namhyung Kim
2016-09-20 14:05 ` Arnaldo Carvalho de Melo
2016-09-13 7:45 ` [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim
2016-09-20 21:41 ` tip-bot for Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-30d476ae738d1ce33f170dd79398ecd211274df6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).